Skip to content

Sync branches 251121-1633: rightlib to main #29336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 23, 2025
Merged

Sync branches 251121-1633: rightlib to main #29336

merged 17 commits into from
Nov 23, 2025
+5,786 −5,072

Conversation

@ydbot
Copy link
Collaborator

@ydbot ydbot commented Nov 21, 2025

PR was created by rightlib sync workflow run

robot-piglet and others added 15 commits November 21, 2025 13:19
@robot-piglet
Intermediate changes
91e9b44 
commit_hash:7c46473c65e9345d84bcc6cc1fcc90efb7e1a006
@dimdim1177
Remove compile depends to codegens with special output folders
bb55dd3 
commit_hash:4ead73401b43578b30e48dd0991f4a9079f89d19
@robot-piglet
Intermediate changes
b95db1b 
commit_hash:634a6e7050be0ef5d6b113e6167d1213044c9524
@vityaman
YQL-20086: Add yql/essentials Clang Tidy config
7294312 
This patch introduces an extension configuration for the Clang Tidy.
It is merged with Arcadia Clang Tidy configuration. To begin with,
more checks for identifiers naming are added.

Documentation: https://nda.ya.ru/t/AhbDZbiF7MKe3M.
commit_hash:3481da4c8df0a4d23a991d4a660ae050d2dc5d33
Add support for OnRaw in TJsonWriter
bedf8ef 
commit_hash:08d34b8a675920b41ee3e2e0d08e1658c9b0ce95
@robot-piglet
Intermediate changes
79cbe2a 
commit_hash:e227fe879645ae86ec05a318d99d8996962186b3
@robot-piglet
Update contrib/python/types-protobuf to 6.32.1.20251105
c4aa7fe 
commit_hash:45d040686ac6113ae9774c853e5473e95feb4d07
add SecureParam to YtflowWrap nodes
b10feee 
commit_hash:9f8b4398bcb1b1d9231f1d677abe2c75c75ba742
@robot-piglet
Intermediate changes
43a5605 
commit_hash:9a5dbe931f528210ec902a424a6bdb850a8662cf
Treat X-Request-Id as a synonym for X-Req-Id
b089a54 
commit_hash:e6bc73c4d54915c96db6c3c684f15e5031f0df67
@robot-piglet
Intermediate changes
b40f0bf 
commit_hash:b7787e3074015ce17dbffc88377a7e535c58634c
Watermarks: YQL: watermarks sql 2.0
b5c7669 
commit_hash:2248d808136868c425ce9ceb05681c37fd108bb8
@vityaman
YQL-20436: Use std::expected at sql_expression
aaaa21e 
This patch introduces a new `TSQLV1Result` for error-handling in
YQL translator.

A nullable `TNodePtr` with 2 states was sufficient
for error reporting, but `YqlSelect` feature fallback mode requires
one more state `YqlSelectUnsupported`.

`TSQLV1Result` is used at `YqlSelect` sub-translator and
`sql_expression`. The last is needed to support `YqlSelect`-subqueries.

For an error-handling `std::expected` is used with `TNonNull` pointer
decorator to prevent implicit casts and ensure safety.

For a legacy code interoperability `Wrap` and `Unwrap` methods where
added. They convert `nullptr` to `ESQLV1Error::Basic` Unwrap is used
in places, where `TSqlExpression` is called without `YqlSelect`
configuration, so `YqlSelectUnsupported` is impossible.

Also I noticed some strange error ignorance at JSON API translation
and added `FIXME`s.
commit_hash:47c1e05ef02574bfd3af4712bd8bfa652ab7868b
@robot-piglet
Intermediate changes
c432a33 
commit_hash:fada69f286415a564c32c3358d8a83d3f06f37c5
@ydbot
Sync branches 251121-1633
fd5324c
@ydbot ydbot requested a review from a team as a code owner November 21, 2025 16:37
@ydbot ydbot added rightlib automerge PR created by sync workflow and will be automerged labels Nov 21, 2025
@github-actions
Copy link

github-actions bot commented Nov 21, 2025 •
edited
Loading

⚪ 2025-11-21 16:38:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for ab9c845 has started.
⚪ 2025-11-21 16:38:39 UTC Artifacts will be uploaded here
⚪ 2025-11-21 16:40:47 UTC ya make is running...
🔴 2025-11-21 17:13:25 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Nov 21, 2025 •
edited
Loading

⚪ 2025-11-21 16:38:25 UTC Pre-commit check linux-x86_64-release-asan for ab9c845 has started.
⚪ 2025-11-21 16:38:44 UTC Artifacts will be uploaded here
⚪ 2025-11-21 16:41:05 UTC ya make is running...
🔴 2025-11-21 17:16:20 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

🟢 2025-11-21 16:57:45 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 21, 2025 •
edited
Loading

⚪ 2025-11-21 21:56:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 98065e8 has started.
⚪ 2025-11-21 21:56:47 UTC Artifacts will be uploaded here
⚪ 2025-11-21 21:58:59 UTC ya make is running...
🟡 2025-11-21 23:55:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41908 39031 0 3 2839 35

⚪ 2025-11-21 23:55:34 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-22 00:05:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73 (only retried tests) 57 0 2 0 14

⚪ 2025-11-22 00:05:54 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-11-22 00:13:58 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31 (only retried tests) 17 0 2 0 12

🟢 2025-11-22 00:14:04 UTC Build successful.
🟡 2025-11-22 00:14:27 UTC ydbd size 2.3 GiB changed* by +193.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6a893e7 merge: 98065e8 diff diff %
ydbd size 2 454 697 008 Bytes 2 454 894 872 Bytes +193.2 KiB +0.008%
ydbd stripped size 523 129 656 Bytes 523 165 016 Bytes +34.5 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 21, 2025 •
edited
Loading

⚪ 2025-11-21 21:57:06 UTC Pre-commit check linux-x86_64-release-asan for 98065e8 has started.
⚪ 2025-11-21 21:57:23 UTC Artifacts will be uploaded here
⚪ 2025-11-21 21:59:35 UTC ya make is running...
🟡 2025-11-21 23:39:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14737 14607 0 74 38 18

🟢 2025-11-21 23:39:34 UTC Build successful.
🟡 2025-11-21 23:40:00 UTC ydbd size 3.8 GiB changed* by +432.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6a893e7 merge: 98065e8 diff diff %
ydbd size 4 109 043 864 Bytes 4 109 486 864 Bytes +432.6 KiB +0.011%
ydbd stripped size 1 527 256 560 Bytes 1 527 400 944 Bytes +141.0 KiB +0.009%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@APozdniakov APozdniakov requested a review from a team as a code owner November 23, 2025 18:09
@github-actions
Copy link

github-actions bot commented Nov 23, 2025 •
edited
Loading

⚪ 2025-11-23 18:13:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 302c1bc has started.
⚪ 2025-11-23 18:13:28 UTC Artifacts will be uploaded here
⚪ 2025-11-23 18:15:43 UTC ya make is running...
🟡 2025-11-23 20:11:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41400 38499 0 6 2858 37

⚪ 2025-11-23 20:11:16 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-23 20:22:17 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
104 (only retried tests) 89 0 0 0 15

🟢 2025-11-23 20:22:24 UTC Build successful.
🟡 2025-11-23 20:22:45 UTC ydbd size 2.3 GiB changed* by +193.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ccff023 merge: 302c1bc diff diff %
ydbd size 2 454 700 312 Bytes 2 454 898 248 Bytes +193.3 KiB +0.008%
ydbd stripped size 523 130 104 Bytes 523 165 528 Bytes +34.6 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 23, 2025 •
edited
Loading

⚪ 2025-11-23 18:13:56 UTC Pre-commit check linux-x86_64-release-asan for 302c1bc has started.
⚪ 2025-11-23 18:14:15 UTC Artifacts will be uploaded here
⚪ 2025-11-23 18:16:29 UTC ya make is running...
🟡 2025-11-23 19:56:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14141 14026 0 77 26 12

🟢 2025-11-23 19:56:47 UTC Build successful.
🟡 2025-11-23 19:57:22 UTC ydbd size 3.8 GiB changed* by +432.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ccff023 merge: 302c1bc diff diff %
ydbd size 4 109 051 312 Bytes 4 109 494 336 Bytes +432.6 KiB +0.011%
ydbd stripped size 1 527 258 672 Bytes 1 527 403 056 Bytes +141.0 KiB +0.009%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ydbot
Copy link
Collaborator Author

ydbot commented Nov 23, 2025

The PR was successfully merged into main using workflow

@ydbot ydbot merged commit d14cebe into main Nov 23, 2025
9 checks passed
@ydbot ydbot deleted the merge-rightlib-251121-1633 branch November 23, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@APozdniakov APozdniakov APozdniakov approved these changes

Assignees

No one assigned

Labels

automerge PR created by sync workflow and will be automerged rightlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ydbot @APozdniakov @robot-piglet @dimdim1177 @vityaman