-
Notifications
You must be signed in to change notification settings - Fork 735
Fix flaky test_pdisk_slot_size_in_units.py #29360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix flaky test_pdisk_slot_size_in_units.py #29360
Conversation
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a flaky test by addressing non-deterministic ordering and timing issues in the PDisk slot size test. The changes include sorting groups for consistency, removing an unreliable assertion, and adding proper wait logic for configuration updates.
- Sorts
self.groupsby GroupId to ensure deterministic ordering when accessed by index - Removes an unreliable BSC PDisk check from
test_change_group_size_in_units - Adds a retryable wait for BSC updates before validating PDisk configuration changes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1485b50 to
1e1f30f
Compare
1e1f30f to
0a3841f
Compare
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changelog category
Description for reviewers