This repository was archived by the owner on Apr 20, 2018. It is now read-only.
Fix revved regex to support extensionless paths #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Added test and fixed build |
|
👍 awesome |
lib/revvedfinder.js
Outdated
|
|
||
| RevvedFinder.prototype.getCandidatesFromFS = function (file, searchPaths) { | ||
| var extname = path.extname(file); | ||
| var regExtname = (extname === '') ? '.' : extname; |
I have an anchor with href='/admin'. I also have a file 'admin.css' in my assets directory. After running `usemin`, it changed to '/admin.css' because revedRx regex in method `RevvedFinder.prototype.getCandidatesFromFS` matches. Why ? Because css extension starts with an hex character.
Author
|
@eddiemonge comments applied and branch rebased ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an anchor with href='/admin'. I also have a file 'admin.css' in my assets directory.
After running
usemin, it changed to '/admin.css' because revedRx regex in methodRevvedFinder.prototype.getCandidatesFromFSmatches.Why ? Because css extension starts with an hex character.