This repository was archived by the owner on Apr 20, 2018. It is now read-only.
Fix for inconsistent line feed #604
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Do you have a test case or example of this that fails without the patch you've supplied? |
|
I can confirm this patch resolves a bug causing the blocks not to be replaced on Windows. Great work @lu4 |
Member
|
Like Addy said, this needs a failing unit test so it can be verified |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the lines with original method not works for cases when the carrige return is inconsistent across the file, it makes the whole block not to get replaced because after concatenation you get a block which is different from original