tvos_common.gn: Enable use_dawn and skia_use_dawn. #7971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are disabled in common.gn, but the Apple build needs both to be on (iosurface_image_backing.mm depends on dawn_shared_texture_cache.cc, for example). Bug: 433180638 Bug: 456692793
Collaborator
Author
fayev-g
approved these changes
Nov 10, 2025
yell0wd0g
reviewed
Nov 11, 2025
Contributor
yell0wd0g
left a comment
yell0wd0g
left a comment
There was a problem hiding this comment.
Post-submit LGTM! On tvOS IIUC we should use Skia on Dawn,
Dawn on Metal. And Angle for GL-like workloads like e.g.
WebGL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are disabled in common.gn, but the Apple build needs both to be on (iosurface_image_backing.mm depends on dawn_shared_texture_cache.cc, for example).
Bug: 433180638
Bug: 456692793