Fix for maxFontSize logic #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is indeed not the most elegant fix, but still miles ahead of just commenting out the entire faulty block 😉 I am currently using this fix, so thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an awesome library thanks for putting it together!
When I implemented I found that the auto sizing was "sticking" to the maxfontsize when the auto-scaled font size was close to the maxFontSize. A couple of debug statements in the font size calculation show that the maxFontSize was getting enforced when the font value was still debouncing.
I added a test that reproduces this bug. The fix that I implemented (fudge factor of 10) isn't super elegant but I think it does the trick considering that it only makes sense to break out of the font size calculation loop when the estimated font size is wildly larger than the maxFontSize.