Add metadata to tool calls, including structured tool output #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdeviant
changed the title
benbrandt
requested changes
Oct 30, 2025
Member
benbrandt
left a comment
benbrandt
left a comment
There was a problem hiding this comment.
We shoudn't have to cache the results, we should be able to send this as multiple tool_call_updates to the same tool call, only updating the fields we are about
Contributor
Author
|
makes sense. I'll update |
gsabran
force-pushed
the
raw-output-hooks
branch
from
37fe1af to
80db249
Compare
gsabran
force-pushed
the
raw-output-hooks
branch
from
cbd818c to
44a43dc
Compare
Contributor
Author
|
Updated, let me know if this is what you expected. There's now a new update that is only relevant as it contains structured output data in the meta parameter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
_metafield for tool calls to forward:Bashetc)The output is received by using the
PostToolUsehook from the SDK. Thetool_call_updatefor the tool result is now only sent when both the hook callback and the original tool result (plain text) have been received.Claude Code describes in its documentation the expected structure of the output for each tools. Unfortunately those are not part of the SDK, and empirically I've found that there was some differences. Still I've found that having this structured output was useful for my client to provide a richer UX. Maybe Zed will too.
I was not sure how to add tests for this change, given the current setup