ollama: Correct tool use for ollama 0.12.10 #42284
Closed
+106
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
Issue:
failure to execute tools (parse error)
solution: change the structure to be able to parse the tool response:
add id to OllamaToolCall (and change from enum to struct)
add index to OllamaFunctionCall
environment:
dockerized ollama: ollama/ollama
ollama/ollama latest d353379de60a 2 days ago 3.65GB
ollama --version
ollama version is 0.12.10
Zed 0.211.6
394f56d
any tool supporting model
i dont expect you to merge this PR, this rust code might be too hacky, but it would be really great to get some logging for ollama in the future in case some model answers do not match expectations anymore. did not find any useful way to enable debugging output for the real agent conversation