Skip to content

Conversation

@puddly
Copy link
Contributor

@puddly puddly commented Oct 30, 2025

Runtime reset during network formation unfortunately didn't benefit from our retrying logic and is adversely affected by multiple resets, causing network formation to currently fail in ZHA for some adapters. This PR moves retrying further into EZSP.

Current bugs:

  1. 2025-10-30 17:14:29.301 WARNING (MainThread) [bellows.uart] Received an unexpected reset: <NcpResetCode.RESET_SOFTWARE: 11> is logged constantly.
  2. Forming a network in ZHA is extremely slow due to the more aggressive retrying and added delays.

I suspect we can replace the three resets with a single reset and a ton of preceding cancel bytes to flush buffers.

@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.55%. Comparing base (02d7870) to head (f1f25a7).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #696   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          58       58           
  Lines        4039     4054   +15     
=======================================
+ Hits         4021     4036   +15     
  Misses         18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puddly puddly marked this pull request as ready for review November 3, 2025 19:36
@puddly puddly merged commit 1ad5b57 into zigpy:dev Nov 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant