Skip to content

Conversation

@JakubKoralewski
Copy link
Contributor

zlib-ng worked better for me, so I exposed it as a feature flag

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @JakubKoralewski, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the flexibility of the crate's compression capabilities by exposing additional feature flags related to the flate2 library. Specifically, it allows users to opt into zlib-ng backends, which can provide optimized compression and decompression performance for those who find it more suitable for their applications.

Highlights

  • New Feature Flags: Introduced deflate-flate2-zlib-ng and deflate-flate2-zlib-ng-compat feature flags in Cargo.toml. These flags enable the use of zlib-ng as an alternative backend for the flate2 compression library, offering more options for compression performance.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a nice enhancement, exposing two new feature flags, deflate-flate2-zlib-ng and deflate-flate2-zlib-ng-compat, to allow using the zlib-ng backend from flate2. This gives users more options for performance tuning. I've added one suggestion to Cargo.toml to add comments for the new features, which will improve consistency and maintainability. Additionally, since these are new user-facing features, please consider documenting them in the README.md file's 'Features' section to help users discover and use them.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Chris Hennick <[email protected]>
@Pr0methean Pr0methean enabled auto-merge November 19, 2025 22:38
@Pr0methean Pr0methean added this pull request to the merge queue Nov 21, 2025
Merged via the queue into zip-rs:master with commit f99a32f Nov 21, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants