Skip to content

Conversation

@hiteshbedre
Copy link
Contributor

Corrected dot(.) matches by adding escape pattern.

Invalid operator string such as operator11passwordiio\/some\text, operator$1password0io\/some\text are also getting matched with current pattern.

Added fix so it will matches only desired string such as operator.1password.io\/some\text

created playground to test pattern: https://regex101.com/r/r5fUXv/1

Copy link
Contributor

@AndyTitu AndyTitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're basically escaping the . symbol which means any char in regex. Lgtm

Rebasing will be needed since this is quite old.

@volodymyrZotov
Copy link
Contributor

/ok-to-test sha=c476a96

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

✅ E2E tests passed.

View test run output

@volodymyrZotov volodymyrZotov merged commit 8cb4728 into 1Password:main Dec 1, 2025
7 checks passed
@volodymyrZotov volodymyrZotov mentioned this pull request Dec 1, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants