Skip to content

Regex: corrected regex pattern to match valid annotation #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
volodymyrZotov merged 5 commits into from
Dec 1, 2025
Merged

Regex: corrected regex pattern to match valid annotation #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a228ea9
regex: updated annotation RegEx pattern
hiteshbedre May 2, 2023
4bcbaef
regex: update RegEx defined under suite
hiteshbedre May 2, 2023
e16dd0d
Merge remote-tracking branch 'upstream/main'
volodymyrZotov Dec 1, 2025
f947ea8
Fix conflicts
volodymyrZotov Dec 1, 2025
c476a96
Properly escape `.` in annotation regexp string
volodymyrZotov Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ const (
restartDeploymentsEnvVariable = "AUTO_RESTART"
defaultPollingInterval = 600

annotationRegExpString = "^operator.1password.io\\/[a-zA-Z\\.]+"
annotationRegExpString = "^operator\\.1password\\.io\\/[a-zA-Z\\.]+"
)

func printVersion() {
Expand Down
2 changes: 1 addition & 1 deletion internal/controller/suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const (
username2 = "test-user2"
password2 = "4zotzqDqXKasLFT2jzTs"

annotationRegExpString = "^operator.1password.io\\/[a-zA-Z\\.]+"
annotationRegExpString = "^operator\\.1password\\.io\\/[a-zA-Z\\.]+"
)

// Define utility constants for object names and testing timeouts/durations and intervals.
Expand Down
2 changes: 1 addition & 1 deletion pkg/onepassword/annotations_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
appsv1 "k8s.io/api/apps/v1"
)

const AnnotationRegExpString = "^operator.1password.io\\/[a-zA-Z\\.]+"
const AnnotationRegExpString = "^operator\\.1password\\.io\\/[a-zA-Z\\.]+"

func TestFilterAnnotations(t *testing.T) {
invalidAnnotation1 := "onepasswordconnect/vaultId"
Expand Down