Run lint and tests in Buildkite CI #3206
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the lint and unit tests CI steps from CircleCI to Buildkite.
It uses an experimental approach to
npmthat:npm ciinstead ofnpm install, as recommended for CI jobsnpm ci, which recreatesnode_modules, only caches the NPM cache.I'm a bit unsure about the approach to be honest. Is the cache gate necessary? What are the chances of race condition? Besides, the performance of using vs not using the cache with
npm cido not seem to be that different, which makes me question whether it's worth having in the first place.Keen to hear what you think. I'd still propose to merge as is and see how it behaves. This investigation has a broader scope that just this project, as we have new Electron apps that might use this new approach.
Test
See green CI.
Release
N.A.