Run lint and tests in Buildkite CI

.buildkite/commands/install_node_dependencies.sh

@@ -0,0 +1,5 @@
+#!/bin/bash -eu
+
+# --legacy-peer-deps is necessary because of react-monaco-editor.
+# See README for more details
+install_npm_packages_clean --legacy-peer-deps

.buildkite/pipeline.yml

@@ -0,0 +1,48 @@
+env:
+  BUILDKITE_PLUGINS_ALWAYS_CLONE_FRESH: 1
+
+steps:
+  - label: Build cache
+    key: build_cache
+    agents:
+      queue: mac
+    env:
+      IMAGE_ID: $IMAGE_ID
+    plugins:
+      - $CI_TOOLKIT_PLUGIN
+      - $NVM_PLUGIN
+    command: |
+      echo "--- :npm: Pre-build npm cache if needed"
+      .buildkite/commands/install_node_dependencies.sh
+
+  - label: Lint
+    key: lint
+    depends_on: build_cache
+    agents:
+      queue: mac
+    env:
+      IMAGE_ID: $IMAGE_ID
+      NODE_ENV: test
+    plugins:
+      - $CI_TOOLKIT_PLUGIN
+      - $NVM_PLUGIN
+    command: |
+      .buildkite/commands/install_node_dependencies.sh
+      echo "--- :eslint: Lint"
+      make lint
+
+  - label: Test
+    key: test
+    depends_on: build_cache
+    agents:
+      queue: mac
+    env:
+      IMAGE_ID: $IMAGE_ID
+      NODE_ENV: test
+    plugins:
+      - $CI_TOOLKIT_PLUGIN
+      - $NVM_PLUGIN
+    command: |
+      .buildkite/commands/install_node_dependencies.sh
+      echo "--- :jest: Test"
+      npm test

.buildkite/shared-pipeline-vars

@@ -0,0 +1,13 @@
+#!/bin/sh
+
+# This file is `source`'d before calling `buildkite-agent pipeline upload`, and can be used
+# to set up some variables that will be interpolated in the `.yml` pipeline before uploading it.
+
+# The ~> modifier is not currently used, but we check for it just in case
+XCODE_VERSION=$(sed -E -n 's/^(~> )?(.*)/xcode-\2/p' .xcode-version)
+CI_TOOLKIT_PLUGIN_VERSION='mokagio/npm_ci'
+NVM_PLUGIN_VERSION='0.3.0'
+
+export IMAGE_ID="$XCODE_VERSION"
+export CI_TOOLKIT_PLUGIN="automattic/a8c-ci-toolkit#$CI_TOOLKIT_PLUGIN_VERSION"
+export NVM_PLUGIN="automattic/nvm#$NVM_PLUGIN_VERSION"

.circleci/config.yml

@@ -98,23 +98,6 @@ jobs:
       - persist_to_workspace:
           root: ~/simplenote
           paths: *app_cache_paths
-  test:
-    docker:
-      - image: cimg/node:18.19.1
-    shell: /bin/bash --login
-    working_directory: ~/simplenote
-    steps:
-      - *install_linux_deps
-      - checkout
-      - *decrypt
-      - *restore_nvm
-      - *setup_nvm
-      - *save_nvm
-      - *npm_restore_cache
-      - *npm_install
-      - run: NODE_ENV=test npm run build
-      - run: npm test
-      - run: npm run lint
 
   linux:
     docker:
@@ -268,8 +251,6 @@ workflows:
     jobs:
       - build:
           filters: *job_filters
-      - test:
-          filters: *job_filters
       - linux:
           requires:
             - build

.xcode-version

@@ -0,0 +1 @@
+15.4