Skip to content

Conversation

@DomAyre
Copy link
Contributor

@DomAyre DomAyre commented Nov 20, 2025

Why

Attempts to build confcom's release package failed for two reasons:

  • The release pipeline runs in a network which prevents network requests to openpolicyagent.org
  • Our windows URL was incorrect because it needs an extra .exe on the end

How

  • Have a map for properties which vary by platform to fix the URL
  • Use GitHub to pull releases instead of directly from OPA

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

Copilot AI review requested due to automatic review settings November 20, 2025 11:46
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Nov 20, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 20, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copilot finished reviewing on behalf of DomAyre November 20, 2025 11:50
@github-actions
Copy link

Hi @DomAyre

⚠️ Release Requirements

Module: confcom

  • ⚠️ Please update VERSION to be 1.4.2 in src/confcom/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 20, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes OPA (Open Policy Agent) installation issues on Windows and in strict networking environments by switching from openpolicyagent.org to GitHub releases and correcting the Windows binary URL to include the .exe extension.

Key Changes:

  • Updated OPA download source from openpolicyagent.org to github.com for better network compatibility
  • Fixed Windows OPA binary URL by adding .exe extension
  • Refactored code to use platform-specific dictionaries for URLs and SHA256 hashes
  • Bumped extension version from 1.4.2 to 1.4.3

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/confcom/setup.py Version bump to 1.4.3
src/confcom/azext_confcom/lib/opa.py Refactored to use GitHub releases with platform-specific URL and SHA256 mappings
src/confcom/HISTORY.rst Added changelog entry for version 1.4.3

@wangzelin007
Copy link
Member

I think we should suuport:
image

@DomAyre
Copy link
Contributor Author

DomAyre commented Nov 20, 2025

Supporting MacOS and ARM would require changes beyond this and the extension generally doesn't support it for now. Doing so would be a wider effort so I think it's outside the scope for this PR

@kairu-ms kairu-ms added skip-cal-version and removed release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. labels Nov 20, 2025
@kairu-ms kairu-ms merged commit 48d9032 into Azure:main Nov 21, 2025
35 of 36 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ confcom ] : https://dev.azure.com/msazure/One/_build/results?buildId=144408448&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants