-
Notifications
You must be signed in to change notification settings - Fork 470
chore(llmobs): skip flaky forking test until tests are rewritten #15554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 251 ± 2 ms. The average import time from base is: 254 ± 3 ms. The import time difference between this PR and base is: -3.4 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate sabrenner/skip-flaky-llmobs-tests-for-now (5c14fca) with baseline main (d238908) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.174µs (SLO: <10.000µs 📉 -48.3%) vs baseline: 📈 +26.0% Memory: ✅ 40.108MB (SLO: <41.000MB -2.2%) vs baseline: +4.3% ✅ ospathbasename_noaspectTime: ✅ 1.082µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -1.4% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.6% ✅ ospathjoin_aspectTime: ✅ 6.173µs (SLO: <10.000µs 📉 -38.3%) vs baseline: +0.1% Memory: ✅ 40.069MB (SLO: <41.000MB -2.3%) vs baseline: +4.1% ✅ ospathjoin_noaspectTime: ✅ 2.284µs (SLO: <10.000µs 📉 -77.2%) vs baseline: -0.1% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.2% ✅ ospathnormcase_aspectTime: ✅ 3.412µs (SLO: <10.000µs 📉 -65.9%) vs baseline: -0.2% Memory: ✅ 40.167MB (SLO: <41.000MB -2.0%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.568µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.2% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.3% ✅ ospathsplit_aspectTime: ✅ 4.702µs (SLO: <10.000µs 📉 -53.0%) vs baseline: -0.7% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.8% ✅ ospathsplit_noaspectTime: ✅ 1.581µs (SLO: <10.000µs 📉 -84.2%) vs baseline: -0.9% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.0% ✅ ospathsplitdrive_aspectTime: ✅ 3.613µs (SLO: <10.000µs 📉 -63.9%) vs baseline: -1.7% Memory: ✅ 40.442MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.2% ✅ ospathsplitdrive_noaspectTime: ✅ 0.698µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.1% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.7% ✅ ospathsplitext_aspectTime: ✅ 4.547µs (SLO: <10.000µs 📉 -54.5%) vs baseline: +1.1% Memory: ✅ 40.147MB (SLO: <41.000MB -2.1%) vs baseline: +4.5% ✅ ospathsplitext_noaspectTime: ✅ 1.385µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +0.4% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.7% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.480µs (SLO: <20.000µs 📉 -82.6%) vs baseline: 📈 +16.8% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.2% ✅ 1-count-metrics-100-timesTime: ✅ 200.865µs (SLO: <220.000µs -8.7%) vs baseline: +0.1% Memory: ✅ 34.996MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +5.5% ✅ 1-distribution-metric-1-timesTime: ✅ 3.378µs (SLO: <20.000µs 📉 -83.1%) vs baseline: -0.4% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.651µs (SLO: <230.000µs -5.4%) vs baseline: -0.6% Memory: ✅ 35.055MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.236µs (SLO: <20.000µs 📉 -88.8%) vs baseline: -1.0% Memory: ✅ 34.996MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +5.6% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.816µs (SLO: <150.000µs -8.1%) vs baseline: +0.6% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.2% ✅ 1-rate-metric-1-timesTime: ✅ 3.180µs (SLO: <20.000µs 📉 -84.1%) vs baseline: +0.8% Memory: ✅ 34.996MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +5.2% ✅ 1-rate-metrics-100-timesTime: ✅ 213.667µs (SLO: <250.000µs 📉 -14.5%) vs baseline: -0.7% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ 100-count-metrics-100-timesTime: ✅ 20.498ms (SLO: <22.000ms -6.8%) vs baseline: +1.1% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.6% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.310ms (SLO: <2.550ms -9.4%) vs baseline: +0.3% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.0% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.418ms (SLO: <1.550ms -8.5%) vs baseline: +0.6% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.229ms (SLO: <2.550ms 📉 -12.6%) vs baseline: -0.5% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.7% ✅ flush-1-metricTime: ✅ 4.689µs (SLO: <20.000µs 📉 -76.6%) vs baseline: +0.7% Memory: ✅ 35.036MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +4.6% ✅ flush-100-metricsTime: ✅ 174.354µs (SLO: <250.000µs 📉 -30.3%) vs baseline: ~same Memory: ✅ 35.095MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.4% ✅ flush-1000-metricsTime: ✅ 2.188ms (SLO: <2.500ms 📉 -12.5%) vs baseline: ~same Memory: ✅ 35.960MB (SLO: <36.500MB 🟡 -1.5%) vs baseline: +4.8% 🟡 Near SLO Breach (18 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
I believe the forking tests for the llmobs service tests are causing timeouts in the CI in this repo, and should be subprocess tests. Should be a simple fix, but until someone from our team has time, I'll just skip them for now. I have created a follow-up ticket for this: https://datadoghq.atlassian.net/browse/MLOB-4843 to hold us accountable