Skip to content

chore(llmobs): skip flaky forking test until tests are rewritten #15554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sabrenner wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(llmobs): skip flaky forking test until tests are rewritten #15554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/llmobs/test_llmobs_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1089,6 +1089,7 @@ def test_listener_hooks_enqueue_correct_writer(run_python_code_in_subprocess):
assert status == 0, err


@pytest.mark.skip("Skipping this test until it is converted properly to a subprocess test")
def test_llmobs_fork_recreates_and_restarts_span_writer():
"""Test that forking a process correctly recreates and restarts the LLMObsSpanWriter."""
with mock.patch("ddtrace.llmobs._writer.BaseLLMObsWriter._send_payload"):
Expand All @@ -1110,6 +1111,7 @@ def test_llmobs_fork_recreates_and_restarts_span_writer():
llmobs_service.disable()


@pytest.mark.skip("Skipping this test until it is converted properly to a subprocess test")
def test_llmobs_fork_recreates_and_restarts_agentless_span_writer():
"""Test that forking a process correctly recreates and restarts the LLMObsSpanWriter."""
with override_global_config(dict(_dd_api_key="<not-a-real-key>")):
Expand All @@ -1132,6 +1134,7 @@ def test_llmobs_fork_recreates_and_restarts_agentless_span_writer():
llmobs_service.disable()


@pytest.mark.skip("Skipping this test until it is converted properly to a subprocess test")
def test_llmobs_fork_recreates_and_restarts_eval_metric_writer():
"""Test that forking a process correctly recreates and restarts the LLMObsEvalMetricWriter."""
with mock.patch("ddtrace.llmobs._writer.BaseLLMObsWriter.periodic"):
Expand All @@ -1153,6 +1156,7 @@ def test_llmobs_fork_recreates_and_restarts_eval_metric_writer():
llmobs_service.disable()


@pytest.mark.skip("Skipping this test until it is converted properly to a subprocess test")
def test_llmobs_fork_recreates_and_restarts_evaluator_runner(mock_ragas_evaluator):
"""Test that forking a process correctly recreates and restarts the EvaluatorRunner."""
pytest.importorskip("ragas")
Expand All @@ -1176,6 +1180,7 @@ def test_llmobs_fork_recreates_and_restarts_evaluator_runner(mock_ragas_evaluato
llmobs_service.disable()


@pytest.mark.skip("Skipping this test until it is converted properly to a subprocess test")
def test_llmobs_fork_create_span(monkeypatch):
"""Test that forking a process correctly encodes new spans created in each process."""
monkeypatch.setenv("_DD_LLMOBS_WRITER_INTERVAL", "5.0")
Expand All @@ -1200,6 +1205,7 @@ def test_llmobs_fork_create_span(monkeypatch):
llmobs_service.disable()


@pytest.mark.skip("Skipping this test until it is converted properly to a subprocess test")
def test_llmobs_fork_evaluator_runner_run(monkeypatch):
"""Test that forking a process correctly encodes new spans created in each process."""
monkeypatch.setenv("DD_LLMOBS_EVALUATOR_INTERVAL", 5.0)
Expand All @@ -1223,6 +1229,7 @@ def test_llmobs_fork_evaluator_runner_run(monkeypatch):
llmobs_service.disable()


@pytest.mark.skip("Skipping this test until it is converted properly to a subprocess test")
def test_llmobs_fork_disabled(monkeypatch):
"""Test that after being disabled the service remains disabled when forking"""
monkeypatch.setenv("DD_LLMOBS_ENABLED", "0")
Expand All @@ -1241,6 +1248,7 @@ def test_llmobs_fork_disabled(monkeypatch):
svc.disable()


@pytest.mark.skip("Skipping this test until it is converted properly to a subprocess test")
def test_llmobs_fork_disabled_then_enabled(monkeypatch):
"""Test that after being initially disabled, the service can be enabled in a fork"""
monkeypatch.setenv("DD_LLMOBS_ENABLED", "0")
Expand Down
Loading