Skip to content

Fixed hash display setting with EIP-712 on Nano devices #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2025
Merged

Fixed hash display setting with EIP-712 on Nano devices #914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/features/signMessageEIP712/ui_logic.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,12 +298,17 @@ bool ui_712_review_struct(const s_struct_712 *struct_ptr) {
bool ui_712_message_hash(void) {
const char *title = "Message hash";

ui_712_set_title(title, strlen(title));
array_bytes_string(strings.tmp.tmp,
sizeof(strings.tmp.tmp),
tmpCtx.messageSigningContext712.messageHash,
KECCAK256_HASH_BYTESIZE);
ui_712_set_value(NULL, 0);
// to prevent showing
// Message hash > Domain hash > Message hash
// as the last three fields
if (!N_storage.displayHash) {
ui_712_set_title(title, strlen(title));
array_bytes_string(strings.tmp.tmp,
sizeof(strings.tmp.tmp),
tmpCtx.messageSigningContext712.messageHash,
KECCAK256_HASH_BYTESIZE);
ui_712_set_value(NULL, 0);
}
ui_ctx->end_reached = true;
return ui_712_redraw_generic_step();
}
Expand Down
Loading