origin/drive_testing

[brendafink]

Before issuing a pull request, please see the contributing page.

[whitehml]

Took a quick 5 min look, just a few comments, not an exhaustive review.

[brendafink]

Thanks, Michael. And yes, we do have a native 1800 5-turn servo per Jeff. He gave it to me and it's on our cart to be installed. Brenda

…

On Monday, December 1, 2025, Michael Whitehurst ***@***.***> wrote: ***@***.**** commented on this pull request. Took a quick 5 min look, just a few comments, not an exhaustive review. ------------------------------ In TeamCode/src/main/java/org/firstinspires/ftc/teamcode/SpiritTeleop.java <#1 (comment)> : > + double RampUpTimer = 0; + boolean ShooterFlag = false; convention would be to use lower-case to start variables, i.e. rampUpTimer & shooterFlag. Starting with upper-case is reserved for classes, like MecanumDrive, Servo, DCMotor, Pose2d, etc. ------------------------------ In TeamCode/src/main/java/org/firstinspires/ftc/teamcode/SpiritTeleop.java <#1 (comment)> : > + } +//------------------CODE FOR WHEN THE TRIGGERS ARE PRESSED---------------------------------- + + if ((gamepad2.left_trigger > 0.25) && (gamepad2.right_trigger < .01)) { + if (ShooterFlag == false) { + ShooterFlag = true; + RampUpTimer = getRuntime() + 2;//set a timer to the length of time the op has been running + 2 seconds + shooter.setPower(.6);//ramp up the shooter + } + //check to see if the shooter has ramped up for the required number of seconds. + //if so, reapply power, advance carousel, engage teardrop, reset teardrop, + //and count how many times the carousel has advanced (at 3, reset it to original position) + if (ShooterFlag == true) { + if (getRuntime() > RampUpTimer) { + if (carouselCounter < 5) { + shooter.setPower(.6); If this line is needed, which i'm not 100% sure it is, you'd want it to happen every cycle (i.e. between if (shooterFlag == true) { & if (getRuntime() > rampUpTimer) {) ------------------------------ In TeamCode/src/main/java/org/firstinspires/ftc/teamcode/SpiritTeleop.java <#1 (comment)> : > + ShooterFlag = true; + RampUpTimer = getRuntime() + 2;//set a timer to the length of time the op has been running + 2 seconds + shooter.setPower(.6);//ramp up the shooter + } + //check to see if the shooter has ramped up for the required number of seconds. + //if so, reapply power, advance carousel, engage teardrop, reset teardrop, + //and count how many times the carousel has advanced (at 3, reset it to original position) + if (ShooterFlag == true) { + if (getRuntime() > RampUpTimer) { + if (carouselCounter < 5) { + shooter.setPower(.6); + //add code to advance carousel by 120 degrees + + //carousel.flipShooterServo(); + //carousel.unflipShooterServo(); + carouselCounter++; The shooterFlag needs to be reset at some point or carouselCounter will blow past 5 in the first few miliseconds of rampUpTimer being exceeded. ------------------------------ In TeamCode/src/main/java/org/firstinspires/ftc/teamcode/SpiritTeleop.java <#1 (comment)> : > + if (getRuntime() > RampUpTimer) { + if (carouselCounter < 5) { + shooter.setPower(.6); + //add code to advance carousel by 120 degrees + + //carousel.flipShooterServo(); + //carousel.unflipShooterServo(); + carouselCounter++; + } else { + //add code to reset carousel to original position + } +//this is a loop to make the code "wait" until the require number of seconds has passed (if statement cannot be empty so we gave it a task to do + // else { + // i = i++; + }else { + i=i++; i++ is already shorthand for i = i + 1 — Reply to this email directly, view it on GitHub <#1 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDNALE5QYYM2HXFSJTCYSQL37RSVXAVCNFSM6AAAAACNUHKOZCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKMRVGY3TAMJXGE> . You are receiving this because you authored the thread.Message ID: <Mars-Robotics-Association/Spirit-quickstart/pull/1/review/3525670171@ github.com>

-- Brenda Fink