[persist] Remove the default set of schemas from the Compactor #33995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are effectively never used in prod - we always have at least one set of schemas available in practice - and once we stop asserting the schemas on handle creation, this would let us write batches that don't match the shard schema.
This has long been the default in every env.
Better than dropping them on the floor!
bkirwi
force-pushed
the
compact-schemas
branch
from
4cacc24 to
9ceb01c
Compare
def-
approved these changes
Nov 3, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are effectively never used in prod - we always have at least one set of schema ids available in practice - and once we stop asserting the schemas on handle creation, this would let us write batches that don't match the shard schema.
Motivation
Partial fix for https://github.com/MaterializeInc/database-issues/issues/9874 - that particular issue is only possible when we fall back on these defaults due to the lazy schema registration.