Skip to content

Conversation

@ninastef
Copy link

tokens in with -> tokens with
have lead -> have led

@ninastef ninastef requested a review from a team as a code owner November 28, 2025 18:47
@changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2025

⚠️ No Changeset found

Latest commit: 8573e1c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 28, 2025

Walkthrough

This pull request contains purely documentation fixes across two files. A grammar correction was made in ERC1155Supply.sol's comment, changing "Total value of tokens in with a given id." to "Total value of tokens with a given id." Additionally, ERC4626.sol's documentation comment was updated to correct the verb tense from "lead" to "led" in the phrase "led to loss of funds." No functional, behavioral, or structural code changes were introduced.

Possibly related PRs

Suggested labels

typo

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: fix typos' is directly related to the changeset, which contains exactly two typo fixes in documentation comments as described in the PR objectives.
Description check ✅ Passed The description clearly lists the two specific typo corrections made in the pull request, directly corresponding to the changes in the two contract files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0131a9 and 8573e1c.

📒 Files selected for processing (2)
  • contracts/token/ERC1155/extensions/ERC1155Supply.sol (1 hunks)
  • contracts/token/ERC20/extensions/ERC4626.sol (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Redirect rules - solidity-contracts
  • GitHub Check: Header rules - solidity-contracts
  • GitHub Check: Pages changed - solidity-contracts
  • GitHub Check: slither
  • GitHub Check: coverage
  • GitHub Check: tests-foundry
  • GitHub Check: tests-upgradeable
  • GitHub Check: halmos
  • GitHub Check: tests
🔇 Additional comments (2)
contracts/token/ERC20/extensions/ERC4626.sol (1)

58-58: LGTM!

Correct grammar fix: "led" is the proper past participle form for "have led to loss of funds."

contracts/token/ERC1155/extensions/ERC1155Supply.sol (1)

29-29: LGTM!

Correct fix: removing the extraneous "in" makes the comment grammatically correct.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arr00 arr00 changed the base branch from master to typo-fixes December 1, 2025 10:52
@arr00 arr00 merged commit 092d342 into OpenZeppelin:typo-fixes Dec 1, 2025
20 of 21 checks passed
This was referenced Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants