feat(ph-ai): agent artifacts schema #41834

kappa90 · 2025-11-20T15:53:29Z

Problem

This PR adds schema definitions for agent artifacts. These artifacts can be visualizations or documents containing markdown, visualization references, and session replay links.

Changes

Added TypeScript schema definitions in frontend/src/queries/schema/schema-assistant-artifacts.ts, and added these schemas to the typegen

How did you test this code?

Added tests for artifact schemas in ee/hogai/core/test/test_artifacts.py

kappa90 · 2025-11-20T15:53:54Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

wiz-7ad640923b · 2025-11-20T15:53:54Z

Wiz Scan Summary

Scanner	Findings
Vulnerabilities	-
Sensitive Data	1
Secrets	-
IaC Misconfigurations	-
SAST Findings	-

Total	1

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

greptile-apps

_{5 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

ee/hogai/core/test/test_artifacts.py

github-actions · 2025-11-20T16:43:15Z

Size Change: 0 B

Total Size: 3.4 MB

ℹ️ View Unchanged

Filename	Size
`frontend/dist/toolbar.js`	3.4 MB

_{compressed-size-action}

skoob13

Left a comment to reduce the schema bloat, as the DevEx team is trying to optimize it.

skoob13 · 2025-11-21T10:08:17Z

frontend/src/queries/schema/schema-assistant-artifacts.ts

+export enum AgentArtifactType {
+    VISUALIZATION = 'visualization',
+    DOCUMENT = 'document',
+}
+
+export interface AgentArtifact {
+    id: string
+    short_id: string
+    name: string
+    type: AgentArtifactType
+    content: AgentArtifactContent
+    conversation: string
+    team: number
+    created_at: string
+}
+
+export interface AgentArtifactMinimal {
+    short_id: string
+    name: string
+    type: AgentArtifactType
+    created_at: string
+}


These are types rather than schema elements. I think we just need to keep AgentArtifactContent here. In Django, it'll be a model; in TypeScript, it'll be a regular interface.

Moved to types, good point

ee/hogai/core/test/test_artifacts.py

kappa90 · 2025-11-21T20:11:16Z

Merge activity

Nov 21, 8:11 PM UTC: @kappa90 merged this pull request with Graphite.

This was referenced Nov 20, 2025

feat(ph-ai): agent modes #41284

Merged

refactor(ph-ai): conversation stream manager to agent executor #41613

Merged

refactor(ph-ai): move chat agent specifics to dedicated classes #41697

Merged

refactor(ph-ai): clean up scaffolding #41713

Merged

kappa90 mentioned this pull request Nov 20, 2025

feat(ph-ai): agent artifacts model #41830

Merged

kappa90 requested a review from a team November 20, 2025 15:54

kappa90 marked this pull request as ready for review November 20, 2025 15:54

kappa90 force-pushed the 11-18-refactor_ph-ai_clean_up_scaffolding branch from 5f3aefb to f57a488 Compare November 20, 2025 15:56

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_schema branch from 7d6d0cb to d153097 Compare November 20, 2025 15:57

greptile-apps bot reviewed Nov 20, 2025

View reviewed changes

ee/hogai/core/test/test_artifacts.py Outdated Show resolved Hide resolved

kappa90 force-pushed the 11-18-refactor_ph-ai_clean_up_scaffolding branch from f57a488 to c22ef9d Compare November 20, 2025 15:58

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_schema branch 2 times, most recently from ebe095b to 1550750 Compare November 20, 2025 15:59

kappa90 changed the base branch from 11-18-refactor_ph-ai_clean_up_scaffolding to graphite-base/41834 November 20, 2025 16:14

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_schema branch 2 times, most recently from ebe095b to 4a0798a Compare November 20, 2025 16:37

kappa90 force-pushed the graphite-base/41834 branch from c22ef9d to 2f258be Compare November 20, 2025 16:37

kappa90 changed the base branch from graphite-base/41834 to 11-20-feat_ph-ai_agent_artifacts_api_endpoint November 20, 2025 16:37

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_api_endpoint branch from 2f258be to b1a4dd3 Compare November 20, 2025 19:26

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_schema branch from 4a0798a to 9563d93 Compare November 20, 2025 19:27

skoob13 requested changes Nov 21, 2025

View reviewed changes

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_schema branch from 9563d93 to f5b979d Compare November 21, 2025 15:11

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_api_endpoint branch from b1a4dd3 to 23c326b Compare November 21, 2025 15:11

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_schema branch from f5b979d to 53ca618 Compare November 21, 2025 15:16

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_api_endpoint branch from 23c326b to b465263 Compare November 21, 2025 15:16

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_schema branch from 53ca618 to dce6db2 Compare November 21, 2025 15:38

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_api_endpoint branch from b465263 to 7031a64 Compare November 21, 2025 15:38

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_schema branch from 99d99bb to 50112ee Compare November 21, 2025 16:25

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_api_endpoint branch from c926489 to 402dc8b Compare November 21, 2025 16:25

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_schema branch from 50112ee to b935249 Compare November 21, 2025 17:02

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_api_endpoint branch from 402dc8b to fc07aea Compare November 21, 2025 17:02

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_schema branch from b935249 to cf07cd8 Compare November 21, 2025 17:05

kappa90 requested a review from skoob13 November 21, 2025 17:06

skoob13 approved these changes Nov 21, 2025

View reviewed changes

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_api_endpoint branch from fc07aea to 84da926 Compare November 21, 2025 17:21

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_schema branch 2 times, most recently from bf9dd24 to 81d72be Compare November 21, 2025 17:22

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_api_endpoint branch 2 times, most recently from 514a053 to e40b7da Compare November 21, 2025 17:23

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_schema branch from 81d72be to d404f4f Compare November 21, 2025 17:23

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_api_endpoint branch from e40b7da to e096ffb Compare November 21, 2025 17:45

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_schema branch from d404f4f to 66d4022 Compare November 21, 2025 17:46

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_api_endpoint branch from e096ffb to 3120090 Compare November 21, 2025 18:03

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_schema branch 2 times, most recently from ba37c70 to a35dd23 Compare November 21, 2025 18:17

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_api_endpoint branch 2 times, most recently from 2101098 to 3f2b627 Compare November 21, 2025 18:53

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_schema branch from a35dd23 to ed59080 Compare November 21, 2025 18:53

graphite-app bot changed the base branch from 11-20-feat_ph-ai_agent_artifacts_api_endpoint to graphite-base/41834 November 21, 2025 19:16

kappa90 force-pushed the graphite-base/41834 branch from 3f2b627 to 892a55c Compare November 21, 2025 19:51

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_schema branch from ed59080 to fa3329f Compare November 21, 2025 19:51

graphite-app bot changed the base branch from graphite-base/41834 to master November 21, 2025 19:51

feat(ph-ai): agent artifacts schema

46bd64f

kappa90 force-pushed the 11-20-feat_ph-ai_agent_artifacts_schema branch from fa3329f to 46bd64f Compare November 21, 2025 19:51

kappa90 merged commit 526e77b into master Nov 21, 2025
199 checks passed

kappa90 deleted the 11-20-feat_ph-ai_agent_artifacts_schema branch November 21, 2025 20:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(ph-ai): agent artifacts schema #41834

feat(ph-ai): agent artifacts schema #41834

Uh oh!

kappa90 commented Nov 20, 2025 •

edited

Loading

Uh oh!

kappa90 commented Nov 20, 2025 •

edited

Loading

Uh oh!

wiz-7ad640923b bot commented Nov 20, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Nov 20, 2025 •

edited

Loading

Uh oh!

skoob13 left a comment

Uh oh!

skoob13 Nov 21, 2025

Uh oh!

kappa90 Nov 21, 2025

Uh oh!

Uh oh!

Uh oh!

kappa90 commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(ph-ai): agent artifacts schema #41834

feat(ph-ai): agent artifacts schema #41834

Uh oh!

Conversation

kappa90 commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

How did you test this code?

Uh oh!

kappa90 commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wiz-7ad640923b bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Wiz Scan Summary

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skoob13 left a comment

Choose a reason for hiding this comment

Uh oh!

skoob13 Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

kappa90 Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kappa90 commented Nov 21, 2025

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kappa90 commented Nov 20, 2025 •

edited

Loading

kappa90 commented Nov 20, 2025 •

edited

Loading

wiz-7ad640923b bot commented Nov 20, 2025 •

edited

Loading

github-actions bot commented Nov 20, 2025 •

edited

Loading