Skip to content

Conversation

@adboio
Copy link
Contributor

@adboio adboio commented Nov 21, 2025

Problem

not many people click the create survey​ button from the feature flag sub-menus, and even fewer follow through to create a survey

i think this is because 1) the button is pretty hidden, and 2) the create-survey-with-AI workflow, as it exists today, is not very good

this PR introduces a new lightweight survey creation modal, embedded as "user feedback" within feature flags

Changes

survey-ff-cross-sell-demo2.mp4 (uploaded via Graphite)

  1. new "quick create" survey modal. currently tailored towards feature flags (shows variants when available), but will be used for other products later
  2. added a new "user feedback" section to feature flags that:
    1. if no survey exists w/ this flag: shows the quick create
    2. if 1 survey exists w/ this flag: shows the survey results
    3. if >1 surveys exist w/ thsi flag: shows table of surveys

next steps:

  1. make this a bit more useful with auto-summarization
  2. bring it out to the actual ff detail page for better viz
  3. use for other products like experiments

How did you test this code?

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Changelog: (features only) Is this feature complete?

Copy link
Contributor Author

adboio commented Nov 21, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

Size Change: +68 B (0%)

Total Size: 3.4 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 3.4 MB +68 B (0%)

compressed-size-action

@adboio adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch 2 times, most recently from 6f6b43d to dbc02e4 Compare November 21, 2025 16:26
@adboio adboio force-pushed the 11-18-feat_surveys_add_index branch 2 times, most recently from d25c4a7 to a08a5cd Compare November 21, 2025 16:27
@adboio adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch 2 times, most recently from 943b3c7 to 32e43dd Compare November 21, 2025 17:10
@adboio adboio force-pushed the 11-18-feat_surveys_add_index branch 2 times, most recently from a848bcc to 0fee956 Compare November 21, 2025 19:29
@adboio adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch 2 times, most recently from 989ba6f to cc81a14 Compare November 21, 2025 21:27
@adboio adboio force-pushed the 11-18-feat_surveys_add_index branch from 0fee956 to c640776 Compare November 21, 2025 21:27
@posthog-bot
Copy link
Contributor

Visual regression: Storybook UI snapshots updated

Mode: UPDATE (triggered by human commit cc81a14)

Changes: 2 snapshots (2 modified, 0 added, 0 deleted)

What this means:

  • Snapshots have been automatically updated to match current rendering
  • Next CI run will switch to CHECK mode to verify stability
  • If snapshots change again, CHECK mode will fail (indicates flapping)

Next steps:

  • Review the changes to ensure they're intentional
  • Approve if changes match your expectations
  • If unexpected, investigate component rendering

Review snapshot changes →

@adboio adboio changed the base branch from 11-18-feat_surveys_add_index to graphite-base/41873 November 21, 2025 21:47
@adboio adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch from 4d7b6c6 to 4273289 Compare November 21, 2025 22:05
@adboio adboio force-pushed the graphite-base/41873 branch from c640776 to 294b0a5 Compare November 21, 2025 22:05
@adboio adboio changed the base branch from graphite-base/41873 to master November 21, 2025 22:05
@posthog-bot
Copy link
Contributor

Visual regression: Storybook UI snapshots updated

Mode: UPDATE (triggered by human commit 4273289)

Changes: 2 snapshots (2 modified, 0 added, 0 deleted)

What this means:

  • Snapshots have been automatically updated to match current rendering
  • Next CI run will switch to CHECK mode to verify stability
  • If snapshots change again, CHECK mode will fail (indicates flapping)

Next steps:

  • Review the changes to ensure they're intentional
  • Approve if changes match your expectations
  • If unexpected, investigate component rendering

Review snapshot changes →

@adboio adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch 2 times, most recently from 3a8d0b9 to 5a038b2 Compare November 22, 2025 02:01
@adboio adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch from 5a038b2 to 8e43946 Compare November 22, 2025 02:38
@adboio adboio requested review from a team November 22, 2025 02:42
@adboio adboio marked this pull request as ready for review November 22, 2025 02:50
@posthog-project-board-bot posthog-project-board-bot bot moved this from Todo to In Review in Feature Flags Nov 22, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@adboio adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch from 8e43946 to 61abcf2 Compare November 22, 2025 04:02
Copy link
Contributor Author

adboio commented Nov 22, 2025

sorry for the monster, ~500 lines are just tests i promise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

3 participants