feat(surveys): add cross-sell button to funnel insights

[adboio]

Problem

survey adoption is incredibly low. my hypothesis is that "surveys" in the sidebar/nav is meaningless to users, and surveys will generally continue to be meaningless until we tell users why they need surveys, what to ask in them, and how to build them.

Changes

⚠️ this change is behind the feature flag survey-funnels-cross-sell, which is currently disabled

original PR: #41574

this PR introduces a new "Ask users why" button on up to 1 funnel insight per dashboard that launches PostHog AI with context about the insight, and a prompt to create a survey.

new survey field: linked_insight_id

added this new field to the survey model so that we don't show the "ask users why" button if the user has already created a survey from this insight

(this PR just adds an index to the db, three previous PRs were merged with additional migrations)

opportunity logic

very simple right now:

• get a list of all insights on the current dashboard
• filter out non-funnel insights
• filter out insights with associated surveys (via surveys.linked_insight_id)
• return funnel with lowest conversion rate

this logic caps "low conversion rate" at <50%, so if there are no funnels with worse than 50% conversion, nothing will be returned.

behavior

• user visits dashboard
• we use above opportunity logic to find a target insight
• if found, "ask users why" button appears
• clicking button launches PostHog AI with prompt & context

How did you test this code?

tested locally

Changelog: (features only) Is this feature complete?

not yet :)

[adboio]

• feat(surveys): add cross-sell button to funnel insights #41703 : 2 dependent PRs (#41694 , #41873 ) 👈 (View in Graphite)
• feat(surveys): add FK for linked_insight_id #41708
• feat(surveys): add linked_insight_id field #41689
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Migration SQL Changes

Hey 👋, we've detected some migrations on this PR. Here's the SQL output for each migration, make sure they make sense:

posthog/migrations/0917_alter_survey_linked_insight.py

--
-- Custom state/database change combination
--

                    CREATE INDEX CONCURRENTLY IF NOT EXISTS "posthog_survey_linked_insight_id_586524f3" ON "posthog_survey" ("linked_insight_id"); -- existing-table-constraint-ignore
                    ;

Last updated: 2025-11-21 21:33 UTC (c640776)

[github-actions]

🔍 Migration Risk Analysis

We've analyzed your migrations for potential risks.

Summary: 0 Safe | 1 Needs Review | 0 Blocked

⚠️ Needs Review

Requires brief lock, review for high-traffic tables

posthog.0917_alter_survey_linked_insight
  └─ #1 ✅ SeparateDatabaseAndState
     Wrapper operation - see nested operations for risk: RunSQL
     database_operations: RunSQL
     └─ #2 ⚠️ RunSQL: CREATE INDEX CONCURRENTLY is safe (non-blocking)

Last updated: 2025-11-21 21:34 UTC (c640776)

[github-actions]

Size Change: +93 B (0%)

Total Size: 3.4 MB

ℹ️ View Unchanged

Filename	Size	Change
frontend/dist/toolbar.js	3.4 MB	+93 B (0%)

_{compressed-size-action}

[greptile-apps]

_{13 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

style: calling useSurveyLinkedInsights() unconditionally makes API request even when feature flag is disabled

Suggested change

	const { data: surveyLinkedInsights, loading: surveyLinkedInsightsLoading } = useSurveyLinkedInsights()
	const { data: surveyLinkedInsights, loading: surveyLinkedInsightsLoading } = featureFlags[FEATURE_FLAGS.SURVEYS_FUNNELS_CROSS_SELL] ? useSurveyLinkedInsights() : { data: new Set<number>(), loading: false }

Prompt To Fix With AI

This is a comment left during a code review.
Path: frontend/src/scenes/dashboard/DashboardItems.tsx
Line: 59:59

Comment:
**style:** calling `useSurveyLinkedInsights()` unconditionally makes API request even when feature flag is disabled

```suggestion
    const { data: surveyLinkedInsights, loading: surveyLinkedInsightsLoading } = featureFlags[FEATURE_FLAGS.SURVEYS_FUNNELS_CROSS_SELL] ? useSurveyLinkedInsights() : { data: new Set<number>(), loading: false }
```

How can I resolve this? If you propose a fix, please make it concise.

[adboio]

conditional hooks huh 🫨

[adboio]

(ig this is valid tho i’ll fix it a different way)

[arthurdedeus]

feels like I've reviewed this before, looks good though

[adboio]

feels like I've reviewed this before, looks good though

you have haha, sorry about that - had to break it down into different PRs to pass migration checks

thank you!!

[adboio]

Merge activity

• Nov 21, 9:47 PM UTC: @adboio merged this pull request with Graphite.