-
Notifications
You must be signed in to change notification settings - Fork 704
ci: Remove the gitlab pipeline runs on pre-merge and post-merge workflows #4538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… workflows. Signed-off-by: pvijayakrish <[email protected]>
WalkthroughThe GitHub Actions trigger-ci workflow is modified to restrict execution to release branches matching a specific naming pattern, removes multiple preparatory steps including repository checkout and source detection, and simplifies the pipeline script by eliminating extensive environment variable generation and replacing it with minimal release-specific variables. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings🪛 actionlint (1.7.8).github/workflows/trigger_ci.yml50-50: "github.event.pull_request.head.ref" is potentially untrusted. avoid using it directly in inline scripts. instead, pass it through an environment variable. see https://docs.github.com/en/actions/reference/security/secure-use#good-practices-for-mitigating-script-injection-attacks for more details (expression) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (2)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| ci_variables["ENABLE_SECURITY_SCAN"]="false" | ||
| ci_variables["RELEASE_BUILD"]="false" | ||
| # Only set required variables for release builds | ||
| ci_variables["NIGHTLY_RUN"]="true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to run a full nightly run which includes benchmarking on every cherry-pick. I think the better flow would be the release pick can choose when / if they want to run gitlab-ci and can just manually run it.
oandreeva-nv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to understand the consequences for kvbm tests
Overview:
Remove the GitLab pipeline runs from the pre-merge and post-merge developer workflows. This update will also automate RC pipeline execution whenever changes are pushed to the release branch or when a new release branch is created.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.