Skip to content

ci: Remove the gitlab pipeline runs on pre-merge and post-merge workflows #4538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: Remove the gitlab pipeline runs on pre-merge and post-merge workflows #4538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 4 additions & 69 deletions .github/workflows/trigger_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,85 +40,20 @@ jobs:

trigger-ci:
name: Trigger CI Pipeline
if: startsWith(github.ref_name, 'release/') && contains(github.ref_name, '.')
environment: GITLAB
needs: mirror_repo
runs-on:
group: gitlab_ci_runners
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Detect source code changes
id: src_changes
uses: dorny/paths-filter@v3
with:
filters: .github/filters.yaml
- name: Check if Validation Workflow has run
id: check_workflow
uses: actions/github-script@v6
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const eventName = context.eventName;
let commit_sha = context.sha;
const workflow_id = 'build-and-test.yml';
if (eventName === 'pull_request') {
commit_sha = context.payload.pull_request.head.sha;
}
const runs = await github.rest.actions.listWorkflowRuns({
owner: context.repo.owner,
repo: context.repo.repo,
workflow_id: workflow_id,
head_sha: commit_sha,
event: eventName
});
const inProgressCount = runs.data.workflow_runs.filter(run => run.status === 'in_progress').length;
const queuedCount = runs.data.workflow_runs.filter(run => run.status === 'queued').length;
const skip_ci = inProgressCount > 0 || queuedCount > 0;
console.log(`Validation Workflow is running: ${skip_ci}`);
core.setOutput('skip_ci', skip_ci.toString());
- name: Trigger Pipeline
run: |
#!/bin/bash -e
declare -A ci_variables

ci_variables["ENABLE_BUILD"]="true"
ci_variables["ENABLE_PREMERGE"]="true"
ci_variables["ENABLE_E2E_TEST"]="true"

# Override to false if validation workflow is running
if [[ "${{ vars.ALLOW_GITLAB_TEST_SKIP }}" == "1" && "${{ steps.check_workflow.outputs.skip_ci }}" == "true" ]]; then
echo "Github Workflow has run and ENABLE_PREMERGE variable value is False"
ci_variables["ENABLE_PREMERGE"]="false"
fi

# Build space-separated FRAMEWORKS variable
frameworks=""
if [ "${{ steps.src_changes.outputs.vllm }}" == "true" ]; then
frameworks+="vllm "
fi

if [ "${{ steps.src_changes.outputs.trtllm }}" == "true" ]; then
frameworks+="trtllm "
fi

if [ "${{ steps.src_changes.outputs.sglang }}" == "true" ]; then
frameworks+="sglang "
fi

# Trim trailing space and set FRAMEWORKS variable if any frameworks detected
frameworks=$(echo "$frameworks" | xargs)
if [ -n "$frameworks" ]; then
ci_variables["FRAMEWORKS"]="$frameworks"
fi

# Set BUILD_ARCHS to empty string to build both amd64 and arm64
ci_variables["BUILD_ARCHS"]=""

# Set additional pipeline variables
ci_variables["ENABLE_PUBLISH_WHEELS"]="false"
ci_variables["ENABLE_JET_BENCHMARKS"]="false"
ci_variables["ENABLE_SECURITY_SCAN"]="false"
ci_variables["RELEASE_BUILD"]="false"
# Only set required variables for release builds
ci_variables["NIGHTLY_RUN"]="true"
Copy link
Contributor

@alec-flowers alec-flowers Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to run a full nightly run which includes benchmarking on every cherry-pick. I think the better flow would be the release pick can choose when / if they want to run gitlab-ci and can just manually run it.

ci_variables["RELEASE_BUILD"]="true"

ci_args=()
for key in "${!ci_variables[@]}"; do
Expand Down
Loading