Skip to content

Conversation

@Divya-N3
Copy link
Contributor

@Divya-N3 Divya-N3 commented Mar 16, 2025

SUMMARY

Add Enterprise SONiC 'mfa' resource module:

  • Provide data definitions in 'argspec'.
  • Implement 'facts' to gather facts for the module.
  • Implement 'config' to apply configurations for merged, deleted, replaced and overridden states.
  • Implement support for 'check' and 'diff' modes.
  • Define regression test cases to verify correct functionality of mfa resource module.

GitHub Issues

List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".

GitHub Issue #
N/A

ISSUE TYPE

  • Feature Pull Request

COMPONENT NAME

  • sonic_mfa

OUTPUT

ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

Regression report:
regression-2025-11-22-19-48-51.pdf

@ArunSaravananBalachandran ArunSaravananBalachandran added the new_resource_module This pull request adds a new resource module label Mar 17, 2025
Copy link
Collaborator

@stalabi1 stalabi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry for this module in meta/runtime.yml and create a symlink.
cd plugins/action
ln -s sonic.py mfa.py

(Resolved)

@stalabi1 stalabi1 added this to the v4.0.0 milestone Jul 29, 2025
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes and corresponding test results look good.

I am requesting a few minor changes to be applied before final approval and merging of this PR.

@kerry-meyer
Copy link
Collaborator

kerry-meyer commented Nov 19, 2025

In addition to making the changes requested via inline comments, please do a regression test run using the instructions posted on the "https://dell.enterprise.slack.com/archives/C0430MPKS8Z" Slack channel and post the resulting output on this PR.

The files and instructions are in the postings on 4/8 and 4/22.

@kerry-meyer
Copy link
Collaborator

Thank you for posting updates for the inline comments I posted. I have resolved all of the associated "Issues" based on the updates that have been pushed to the PR branch.

A fix for the sanity errors flagged recently for all modules was merged today and your latest changes should eliminate these failures for the MFA module. If you resync the 'main' branch of your fork, then resync this PR branch from your fork "main" branch, that should allow all sanity tests to pass.

This PR can be approved and merged after an updated regression test report with "check" mode and "diff" mode output is attached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new_resource_module This pull request adds a new resource module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants