-
Notifications
You must be signed in to change notification settings - Fork 85
Add Dell Enterprise SONiC 'mfa' module #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an entry for this module in meta/runtime.yml and create a symlink.
cd plugins/action
ln -s sonic.py mfa.py
(Resolved)
kerry-meyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed changes and corresponding test results look good.
I am requesting a few minor changes to be applied before final approval and merging of this PR.
|
In addition to making the changes requested via inline comments, please do a regression test run using the instructions posted on the "https://dell.enterprise.slack.com/archives/C0430MPKS8Z" Slack channel and post the resulting output on this PR. The files and instructions are in the postings on 4/8 and 4/22. |
|
Thank you for posting updates for the inline comments I posted. I have resolved all of the associated "Issues" based on the updates that have been pushed to the PR branch. A fix for the sanity errors flagged recently for all modules was merged today and your latest changes should eliminate these failures for the MFA module. If you resync the 'main' branch of your fork, then resync this PR branch from your fork "main" branch, that should allow all sanity tests to pass. This PR can be approved and merged after an updated regression test report with "check" mode and "diff" mode output is attached. |
SUMMARY
Add Enterprise SONiC 'mfa' resource module:
GitHub Issues
List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".
ISSUE TYPE
COMPONENT NAME
OUTPUT
ADDITIONAL INFORMATION
Checklist:
Regression report:
regression-2025-11-22-19-48-51.pdf