-
Notifications
You must be signed in to change notification settings - Fork 85
Add Dell Enterprise SONiC 'mfa' module #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Divya-N3
wants to merge
28
commits into
ansible-collections:main
Choose a base branch
from
Divya-N3:mfa
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
b7096ca
Add Dell Enterprise SONiC 'mfa' module
469f423
Resolved sanity errors
29b3d72
Merge branch 'ansible-collections:main' into mfa
Divya-N3 10a83a0
Merge branch 'main' into mfa
Divya-N3 12b4be9
Addressing review comments
1537bd9
Merge branch 'main' into mfa
Divya-N3 0ab18ad
Merge branch 'ansible-collections:main' into mfa
Divya-N3 9a44d6d
Fixed check mode issue
0e04957
Fixed sanity error
219e989
Merge branch 'main' into mfa
Divya-N3 d21821b
Addressing review comments
bfac149
Merge branch 'main' into mfa
Divya-N3 9f9431b
Merge branch 'main' into mfa
Divya-N3 345a600
Merge branch 'ansible-collections:main' into mfa
Divya-N3 d60b7ff
Addressing review comments
5c9f452
Changes in replace function
3086216
Addressing review comments
690b0ad
Addressing nested dict review comment
de20fca
Merge branch 'ansible-collections:main' into mfa
Divya-N3 a069364
Addressing review comments
8227989
Creating symlink
881fdb5
Refactored regression prep and cleanup tasks
6c89925
Adressing lint issues
9d1af97
Addressing sanity error
8170d3d
Addressing review comments
55640dd
Addressing review comments of overridden state
97ce96f
Addressing review comments
96a2f0b
Merge branch 'ansible-collections:main' into mfa
Divya-N3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| sonic.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| # | ||
| # -*- coding: utf-8 -*- | ||
| # Copyright 2025 Dell Inc. or its subsidiaries. All Rights Reserved | ||
| # GNU General Public License v3.0+ | ||
| # (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt) | ||
|
|
||
| """ | ||
| The arg spec for the sonic_mfa module | ||
| """ | ||
|
|
||
| from __future__ import (absolute_import, division, print_function) | ||
| __metaclass__ = type | ||
|
|
||
|
|
||
| class MfaArgs(object): # pylint: disable=R0903 | ||
| """The arg spec for the sonic_mfa module | ||
| """ | ||
|
|
||
| def __init__(self, **kwargs): | ||
| pass | ||
|
|
||
| argument_spec = { | ||
| 'config': { | ||
| 'options': { | ||
| 'cac_piv_global': { | ||
| 'options': { | ||
| 'cert_username_field': { | ||
| 'choices': [ | ||
| 'common-name', | ||
| 'common-name-or-user-principal-name', | ||
| 'user-principal-name' | ||
| ], | ||
| 'type': 'str' | ||
| }, | ||
| 'cert_username_match': { | ||
| 'choices': [ | ||
| '10digit-username', | ||
| 'first-name', | ||
| 'username-as-is', | ||
| 'username-without-domain' | ||
| ], | ||
| 'type': 'str' | ||
| }, | ||
| 'security_profile': {'type': 'str'} | ||
| }, | ||
| 'type': 'dict' | ||
| }, | ||
| 'mfa_global': { | ||
| 'options': { | ||
| 'client_secret': {'no_log': True, 'type': 'str'}, | ||
| 'client_secret_encrypted': {'type': 'bool'}, | ||
| 'key_seed': {'no_log': True, 'type': 'str'}, | ||
| 'key_seed_encrypted': {'type': 'bool'}, | ||
| 'security_profile': {'type': 'str'} | ||
| }, | ||
| 'type': 'dict' | ||
| }, | ||
| 'rsa_global': { | ||
| 'options': { | ||
| 'security_profile': {'type': 'str'} | ||
| }, | ||
| 'type': 'dict' | ||
| }, | ||
| 'rsa_servers': { | ||
| 'elements': 'dict', | ||
| 'options': { | ||
| 'client_id': {'type': 'str'}, | ||
| 'client_key': {'no_log': True, 'type': 'str'}, | ||
| 'client_key_encrypted': {'type': 'bool'}, | ||
| 'connection_timeout': {'type': 'int'}, | ||
| 'hostname': {'required': True, 'type': 'str'}, | ||
| 'read_timeout': {'type': 'int'}, | ||
| 'server_port': {'type': 'int'} | ||
| }, | ||
| 'type': 'list' | ||
| } | ||
| }, | ||
| 'type': 'dict' | ||
| }, | ||
| 'state': { | ||
| 'choices': ['merged', 'deleted', 'replaced', 'overridden'], | ||
| 'default': 'merged', 'type': 'str' | ||
| } | ||
| } # pylint: disable=C0301 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.