Move out some exceptions to TaskSDK #54505

ephraimbuddy · 2025-08-14T13:17:00Z

As part of the ongoing server/client separation,
this commit moves out some exceptions to the Task sdk.

task-sdk/tests/task_sdk/execution_time/test_task_runner.py

airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py

airflow-core/src/airflow/api_fastapi/core_api/routes/public/extra_links.py

airflow-core/src/airflow/api_fastapi/core_api/routes/public/log.py

airflow-core/src/airflow/api_fastapi/execution_api/routes/connections.py

airflow-core/src/airflow/models/connection.py

ashb · 2025-10-29T12:24:02Z

@ephraimbuddy Ah, maybe in those shared library tests we should set _AIRFLOW__AS_LIBRARY env var early in pytest_configure inside conftest.py

ephraimbuddy · 2025-10-29T12:59:05Z

@ephraimbuddy Ah, maybe in those shared library tests we should set _AIRFLOW__AS_LIBRARY env var early in pytest_configure inside conftest.py

The shared modules already set the _AIRFLOW__AS_LIBRARY in conftest.py

As part of the ongoing server/client separation, this commit moves out some exceptions to the Task sdk. The AirflowException usage in task sdk has been changed to RuntimeError. Also, the TaskNotFound exception is still duplicated due to the many usages in core API and SDK. Rename back RuntimeError to AirflowException expose TaskNotFound import from exceptions completely separate sdk imports fix conflicts Keep base AirflowException only in sdk import some exception from sdk into core exceptions add to be deprecated function to handle TaskNotFound and ParamValidationError catch some import error in airflow.exceptions and redefine the exceptions Core should not raise exceptions Move some exceptions to deprecated Raise RuntimeError instead of AirflowException in SDK Rename AirflowException in SDK to AirflowSDKException Update tests Remove AirflowNotFound in sdk exceptions Catch import errors for exceptions in example dags remove get_task redefine Import AirflowSensorTimeout properly and Remove airflowNotFoundException import from sdk Remove AirflowFailException in core Import AirflowException from core with a compat shim Fix import Use the sdk AirflowException in core and fix other exceptions raise ValueError in sparkhook

…founderror

…dulenotfounderror

… the real error would raise

…so that the real error would raise

…r connections

…er changes

…flowException to RuntimeError

boring-cyborg bot added the area:task-sdk label Aug 14, 2025

ashb reviewed Aug 14, 2025

View reviewed changes

task-sdk/tests/task_sdk/execution_time/test_task_runner.py Outdated Show resolved Hide resolved

ephraimbuddy force-pushed the exception-separation branch 3 times, most recently from f4a380e to 7a4587c Compare August 15, 2025 07:48

ephraimbuddy marked this pull request as ready for review August 15, 2025 07:51

ephraimbuddy requested review from XD-DENG, amoghrajesh, bolkedebruin, bugraoz93, jason810496, kaxil, pierrejeambrun, rawwar and shubhamraj-git as code owners August 15, 2025 07:51

ephraimbuddy force-pushed the exception-separation branch from fdff489 to 91d4cc0 Compare August 15, 2025 15:37