Skip to content

Amend time-machine update in unit tests #58454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2025
Merged

Amend time-machine update in unit tests #58454

merged 2 commits into from
Nov 19, 2025
+2 −1

Conversation

@bugraoz93
Copy link
Contributor

@bugraoz93 bugraoz93 commented Nov 18, 2025

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

jscheffl
jscheffl approved these changes Nov 18, 2025
View reviewed changes
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you were faster than me!

One small sanity question before merge...

potiuk
potiuk approved these changes Nov 18, 2025
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

This was referenced Nov 18, 2025
Merged
Merged
@bugraoz93
Copy link
Contributor Author

bugraoz93 commented Nov 18, 2025

Seems providers are impacted as well will update before merge it in a moment

@bugraoz93 bugraoz93 force-pushed the task-instance-time-machine-update branch from b38e26e to fc677be Compare November 18, 2025 23:00
@bugraoz93 bugraoz93 requested a review from o-nikolas as a code owner November 18, 2025 23:00
@bugraoz93 bugraoz93 requested a review from kaxil as a code owner November 18, 2025 23:03
@bugraoz93
Copy link
Contributor Author

bugraoz93 commented Nov 18, 2025

Okay, and some in task-sdk tests :) Added those as well

@bugraoz93
Copy link
Contributor Author

bugraoz93 commented Nov 18, 2025

devel-common pays off well while managing these updates for breaking changes

@bugraoz93 bugraoz93 changed the title Amend time-machine update in ti test Amend time-machine update in unit tests Nov 18, 2025
@bugraoz93
Copy link
Contributor Author

bugraoz93 commented Nov 18, 2025

There are other issues with DBT Cloud and task-sdk. One is below, which seems hanging. task-sdk failures seem unrelated, but I will double-check

2025-11-18T23:25:47.7701781Z 1970-01-01T00:16:47.042294Z [info     ] Getting the status of job run 5555. [airflow.task.hooks.airflow.providers.dbt.cloud.hooks.dbt.DbtCloudHook]
2025-11-18T23:25:47.7702297Z 1970-01-01T00:16:47.042294Z [info     ] Current status of job run 5555: RUNNING [airflow.task.hooks.airflow.providers.dbt.cloud.hooks.dbt.DbtCloudHook]
2025-11-18T23:25:47.7702663Z 1970-01-01T00:16:48.042336Z [info     ] Getting the status of job run 5555. [airflow.task.hooks.airflow.providers.dbt.cloud.hooks.dbt.DbtCloudHook]
2025-11-18T23:25:47.7703044Z 1970-01-01T00:16:48.042336Z [info     ] Current status of job run 5555: RUNNING [airflow.task.hooks.airflow.providers.dbt.cloud.hooks.dbt.DbtCloudHook]

@bugraoz93
Copy link
Contributor Author

bugraoz93 commented Nov 18, 2025

It doesn't seem like it is related because test_heartbeat_failures_handling already conforms to the changes in time-machine

@bugraoz93
Copy link
Contributor Author

bugraoz93 commented Nov 18, 2025

Okay, all using time-machine but in the correct manner. This looks suspicious if the update is really working in all cases 🤔

@bugraoz93
Copy link
Contributor Author

bugraoz93 commented Nov 18, 2025

They are not importing time-machine or seeing it from it, maybe that's the reason

@bugraoz93
Copy link
Contributor Author

bugraoz93 commented Nov 18, 2025

They introduced time-machine[dateutil] but that fails even worse. Trying some other things

@bugraoz93
Copy link
Contributor Author

bugraoz93 commented Nov 19, 2025

Maybe it is easier to version cap to a higher version if we cannot find it, because I see there are lots of tests following the new notation and they are not failing

@potiuk
Copy link
Member

potiuk commented Nov 19, 2025

Maybe it is easier to version cap to a higher version if we cannot find it, because I see there are lots of tests following the new notation and they are not failing

Yes. And create an issue to upgrade it.

@bugraoz93 bugraoz93 mentioned this pull request Nov 19, 2025
Open
1 task
@bugraoz93 bugraoz93 force-pushed the task-instance-time-machine-update branch from bac3f9f to c428e28 Compare November 19, 2025 00:25
@bugraoz93
Copy link
Contributor Author

bugraoz93 commented Nov 19, 2025

Reverted the changes and added a version cap to time-machine. Created the issue as well. I need to go to bed :)

potiuk
potiuk reviewed Nov 19, 2025
View reviewed changes
@potiuk potiuk merged commit fd3c5ce into apache:main Nov 19, 2025
91 checks passed
amoghrajesh pushed a commit that referenced this pull request Nov 19, 2025
@bugraoz93 @potiuk @amoghrajesh
[v3-1-test] Amend time-machine update in unit tests (#58454)
b5080f4 
* add version cap to time-machine

* Apply suggestion from @potiuk

---------
(cherry picked from commit fd3c5ce)

Co-authored-by: Bugra Ozturk <[email protected]>
Co-authored-by: Jarek Potiuk <[email protected]>
@amoghrajesh
Copy link
Contributor

amoghrajesh commented Nov 19, 2025

We will need this restriction in v3 branch as well

@amoghrajesh
Copy link
Contributor

amoghrajesh commented Nov 19, 2025

Manual cherry pick here: #58486

potiuk added a commit that referenced this pull request Nov 19, 2025
@amoghrajesh @bugraoz93 @potiuk
[v3-1-test] Amend time-machine update in unit tests (#58454) (#58486)
5610f62 
* add version cap to time-machine

* Apply suggestion from @potiuk

---------
(cherry picked from commit fd3c5ce)

Co-authored-by: Bugra Ozturk <[email protected]>
Co-authored-by: Jarek Potiuk <[email protected]>
ephraimbuddy pushed a commit that referenced this pull request Nov 19, 2025
@amoghrajesh @bugraoz93
@potiuk @ephraimbuddy
[v3-1-test] Amend time-machine update in unit tests (#58454) (#58486)
863e792 
* add version cap to time-machine

* Apply suggestion from @potiuk

---------
(cherry picked from commit fd3c5ce)

Co-authored-by: Bugra Ozturk <[email protected]>
Co-authored-by: Jarek Potiuk <[email protected]>
aaron-wolmutt pushed a commit to aaron-wolmutt/airflow that referenced this pull request Nov 20, 2025
@bugraoz93 @potiuk @aaron-wolmutt
Amend time-machine update in unit tests (apache#58454)
163f04d 
* add version cap to time-machine

* Apply suggestion from @potiuk

---------

Co-authored-by: Jarek Potiuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@jscheffl jscheffl jscheffl approved these changes

@ashb ashb Awaiting requested review from ashb

@gopidesupavan gopidesupavan Awaiting requested review from gopidesupavan

@amoghrajesh amoghrajesh Awaiting requested review from amoghrajesh

@o-nikolas o-nikolas Awaiting requested review from o-nikolas

@kaxil kaxil Awaiting requested review from kaxil

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bugraoz93 @potiuk @amoghrajesh @jscheffl