Stabilize MethodConfigTest by disabling metrics initialization to avoid Micrometer nondeterminism
#15782
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
This PR stabilizes the following tests in
MethodConfigTest:testOverrideMethodConfigOfServicetestAddMethodConfigOfServicetestOverrideMethodConfigOfReferencetestAddMethodConfigOfReferencetestIgnoreInvalidMethodConfigOfServiceThese tests were intermittently failing under randomized execution orders (NonDex) due to nondeterministic behavior in Micrometer’s composite meter registry. The tests focus on method-level configuration overrides and do not intend to validate metrics behavior. Yet, the metrics subsystem was being initialized as part of the bootstrap process, introducing unnecessary nondeterminism.
Root Cause
During application bootstrap, Dubbo initializes the metrics subsystem, which in turn configures Micrometer’s composite meter registry. Internally, Micrometer uses an
IdentityHashMapwhose iteration behavior is not deterministic under randomized JVM execution orders.Under certain NonDex seeds, this produces:
These failures occur before the tests exercise any method-configuration logic, so the flakiness is caused purely by nondeterministic metrics initialization and not by the
MethodConfigfunctionality under test.Changes Made
MethodConfigTest.SysProps.clear()in@BeforeEachandDubboBootstrap.reset()in@AfterEach, so no metrics/config-related state leaks across tests.Verification
You can try running the following snippet of code from the dubbo repo root, on both pre-fix and post-fix code
The tests should fail intermittently on the pre-fix version, but pass consistently across all seeds on the post-fix version.
NonDex run logs will be available under the
dubbo-config/dubbo-config-api/.nondexdirectory.Checklist