[SPARK-54240] Translate get array item catalyst expression to connector expression #52940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urosstan-db
commented
Nov 10, 2025
| @@ -326,6 +326,9 @@ class V2ExpressionBuilder(e: Expression, isPredicate: Boolean = false) extends L | |||
| case _: Sha2 => generateExpressionWithName("SHA2", expr, isPredicate) | |||
| case _: StringLPad => generateExpressionWithName("LPAD", expr, isPredicate) | |||
| case _: StringRPad => generateExpressionWithName("RPAD", expr, isPredicate) | |||
| case GetArrayItem(_, _, failOnError) if failOnError => | |||
| // Pushdown only if ANSI is enabled (fail on error) to be compatible with remote systems. | |||
| generateExpressionWithName("GET_ARRAY_ITEM", expr, isPredicate) | |||
Contributor
Author
There was a problem hiding this comment.
We can make new v2 expression as well to be able to pass failOnError argument, since get method in spark returns 0-indexed element of array, but it does not fail for index out of bounds, so it would be beneficial to pass failOnError to be able to support get method pushdown beside bracket access. WDYT @srielau @cloud-fan ?
urosstan-db
commented
Nov 10, 2025
| @@ -1629,6 +1629,12 @@ | |||
| ], | |||
| "sqlState" : "42846" | |||
| }, | |||
Contributor
Author
There was a problem hiding this comment.
I did not find we have similar non legacy error. Legacy errors are usually too specific, e.g. unsupported function.
cloud-fan
reviewed
Nov 11, 2025
|
|
||
| public Expression getChildArray() { return this.childArray; } | ||
| public Expression getOrdinal() { return this.ordinal; } | ||
| public boolean getFailOnError() { return this.failOnError; } |
Contributor
There was a problem hiding this comment.
I don't see the get prefix in other v2 expressions such as Cast. Can we be consistent here?
Contributor
Author
There was a problem hiding this comment.
Yes, makes sense 😄
cloud-fan
approved these changes
Nov 11, 2025
urosstan-db
force-pushed
the
SPARK-54240-support-get-array-item-pushdown
branch
from
bbdd90a to
81ddd91
Compare
cloud-fan
reviewed
Nov 12, 2025
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GetArrayItem.java
Outdated
Show resolved
Hide resolved
…essions/GetArrayItem.java
Contributor
|
thanks, merging to master/4.1! |
cloud-fan
added a commit
that referenced
this pull request
Nov 12, 2025
…or expression ### What changes were proposed in this pull request? - Support conversion of catalyst GetArrayItem expression to connector expression to allow data sources to implement pushdown of this expression ### Why are the changes needed? - To allow data sources (built-in and third-party) to implement pushdown of get array item ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No testing needed, since we did not implement pushdowns yet ### Was this patch authored or co-authored using generative AI tooling? No Closes #52940 from urosstan-db/SPARK-54240-support-get-array-item-pushdown. Lead-authored-by: Uros Stankovic <[email protected]> Co-authored-by: Wenchen Fan <[email protected]> Co-authored-by: Uros Stankovic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 05b0543) Signed-off-by: Wenchen Fan <[email protected]>
Member
|
Thank you all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
No testing needed, since we did not implement pushdowns yet
Was this patch authored or co-authored using generative AI tooling?
No