-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-54240] Translate get array item catalyst expression to connector expression #52940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
urosstan-db
wants to merge
8
commits into
apache:master
from
urosstan-db:SPARK-54240-support-get-array-item-pushdown
Closed
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e4d3f63
Translate get array item catalyst expression to connector expression
urosstan-db c383370
Implement ToStringSQLBuilder
urosstan-db 09b2d99
Use separate expression for get array item translation
urosstan-db 3b0318f
Introduce new error code
urosstan-db 1c27c59
Fix building of get array item
urosstan-db 81ddd91
Rename getters
urosstan-db 787315c
Update sql/catalyst/src/main/java/org/apache/spark/sql/connector/expr…
cloud-fan 9f75dd8
nit: add whitespace
urosstan-db File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GetArrayItem.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.connector.expressions; | ||
|
|
||
| import org.apache.spark.annotation.Evolving; | ||
| import org.apache.spark.sql.internal.connector.ExpressionWithToString; | ||
|
|
||
| /** | ||
| * Get array item expression. | ||
| * | ||
| * @since 4.1.0 | ||
| */ | ||
|
|
||
| @Evolving | ||
| public class GetArrayItem extends ExpressionWithToString { | ||
|
|
||
| private final Expression childArray; | ||
| private final Expression ordinal; | ||
| private final boolean failOnError; | ||
|
|
||
| /** | ||
| * Creates GetArrayItem expression. | ||
| * @param childArray Array that is source to get element from. Child of this expression. | ||
| * @param ordinal Ordinal of element. Zero-based indexing. | ||
| * @param failOnError Whether expression should throw exception for index out of bound or to | ||
| * return null. | ||
| */ | ||
| public GetArrayItem(Expression childArray, Expression ordinal, boolean failOnError) { | ||
| this.childArray = childArray; | ||
| this.ordinal = ordinal; | ||
| this.failOnError = failOnError; | ||
| } | ||
|
|
||
| public Expression childArray() { return this.childArray; } | ||
| public Expression ordinal() { return this.ordinal; } | ||
| public boolean failOnError() { return this.failOnError; } | ||
|
|
||
| @Override | ||
| public Expression[] children() { return new Expression[]{ childArray() }; } | ||
cloud-fan marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find we have similar non legacy error. Legacy errors are usually too specific, e.g. unsupported function.