Skip to content

[ty] Add code action to ignore diagnostic on the current line #21595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 29, 2025
Merged

[ty] Add code action to ignore diagnostic on the current line #21595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
61911b8
[ty] Add code action to suppress diagnostic on current line
MichaReiser Nov 23, 2025
197bba4
Discard changes to crates/ty_server/src/server/api/diagnostics.rs
MichaReiser Nov 28, 2025
f3f8cb2
Nit
MichaReiser Nov 28, 2025
6818e03
Add code actions testing infrastructure
MichaReiser Nov 28, 2025
1fe5c19
More tests, handle multiline strings, line continuation, and interpol…
MichaReiser Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .config/nextest.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ serial = { max-threads = 1 }
filter = 'binary(file_watching)'
test-group = 'serial'

[[profile.default.overrides]]
filter = 'binary(e2e)'
test-group = 'serial'

Comment on lines -10 to -13
Copy link
Member Author

@MichaReiser MichaReiser Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is no longer needed, since I increased the request wait limit in e2e tests.

[profile.ci]
# Print out output for failing tests as soon as they fail, and also at the end
# of the run (for easy scrollability).
Expand Down
4 changes: 4 additions & 0 deletions crates/ruff_diagnostics/src/fix.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,10 @@ impl Fix {
&self.edits
}

pub fn into_edits(self) -> Vec<Edit> {
self.edits
}

/// Return the [`Applicability`] of the [`Fix`].
pub fn applicability(&self) -> Applicability {
self.applicability
Expand Down
Loading