ci: exclude dc for timing #2896
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougch
force-pushed
the
dougch/timing
branch
from
192dc66 to
624f493
Compare
boquan-fang
reviewed
Nov 19, 2025
| build: | ||
| commands: | ||
| - cargo build --timings --release | ||
| - cargo build --timings --release --workspace --exclude s2n-quic-dc-metrics |
Contributor
There was a problem hiding this comment.
Do you know which version of rust are we using exactly for CargoTiming? I thought the rust version in this job is using 1.91.1. Why is it failing on s2n-quic-dc-metrics which only requires 1.88.0?
The error says:
[Instance] <Time Stamp> Running command cargo test --workspace
--
error: rustc 1.84.0 is not supported by the following packages:
[email protected] requires rustc 1.88
[email protected] requires rustc 1.88
[email protected] requires rustc 1.88
The installing rust step says:
[Instance] <Time> Running command curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs \| sh -s -- -y
--
...
stable-x86_64-unknown-linux-gnu unchanged - rustc 1.91.1 (ed61e7d7e 2025-11-07)
Rust is installed now. Great!
Where is 1.84.0 coming from in this job?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
n/a
Description of changes:
We split the MSRV for s2n-quic-dc, so exclude it from the build/test timing metric.
Call-outs:
Testing:
Ad-hoc test passed. This runs on a schedule, so PR won't catch the failures.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.