Skip to content

ci: exclude dc for timing #2896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

ci: exclude dc for timing #2896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions codebuild/spec/cargotiming.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,14 @@ phases:
- yum update -y && yum install -y cmake
build:
commands:
- cargo build --timings --release
- cargo build --timings --release --workspace --exclude s2n-quic-dc-metrics
Copy link
Contributor

@boquan-fang boquan-fang Nov 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know which version of rust are we using exactly for CargoTiming? I thought the rust version in this job is using 1.91.1. Why is it failing on s2n-quic-dc-metrics which only requires 1.88.0?

The error says:

[Instance] <Time Stamp> Running command cargo test --workspace
--
error: rustc 1.84.0 is not supported by the following packages:
[email protected] requires rustc 1.88
[email protected] requires rustc 1.88
[email protected] requires rustc 1.88

The installing rust step says:

[Instance] <Time> Running command curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs \| sh -s -- -y
--
...
 
stable-x86_64-unknown-linux-gnu unchanged - rustc 1.91.1 (ed61e7d7e 2025-11-07)
 
 
Rust is installed now. Great!

Where is 1.84.0 coming from in this job?

Copy link
Contributor

@jouho jouho Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.84 is coming from the msrv set by rust-toolchain:

s2n-quic/rust-toolchain

Line 2 in be4d982

channel = "1.84.0"

I believe we have two options depending on the intent:

  1. If the intent is to include dc-quic in the timing job, we need to upgrade msrv in rust-toolchain to at least 1.88
  2. If the intent is to exclude dc-quic from the timing job, we simply replace cargo test --workspace with cargo test

post_build:
commands:
- cargo test --workspace
- cargo test --timings --workspace --exclude s2n-quic-dc-metrics

artifacts:
# upload timing reports
files:
- '**/*'
base-directory: target/cargo-timings

Loading