fix: Hardhat artifact imports and contract factory usage #2598
Conversation
jubeira
left a comment
jubeira
left a comment
There was a problem hiding this comment.
Thanks for sending this @defiberrys.
Curious how you got there. The helpers under pvt might not be perfectly written, but they don't seem to have any apparent issues either. Do you see any specific problem with the current implementation that brings in internal imports?
| const artifact = getArtifact(contract); | ||
|
|
||
| const factory = await ethers.getContractFactoryFromArtifact(artifact, { signer: from, libraries }); | ||
| const factory = await ethers.getContractFactory(artifact.abi, artifact.bytecode, from); |
There was a problem hiding this comment.
I think we also would need to send the libraries to link here: https://v2.hardhat.org/hardhat-runner/plugins/nomicfoundation-hardhat-ethers
| } | ||
|
|
||
| const artifacts = new Artifacts(artifactsPath); | ||
| return artifacts.readArtifactSync(contract.split('/').slice(-1)[0]); |
There was a problem hiding this comment.
So we don't need the artifactsPath anymore? how is the global artifacts linked to the path in this case, considering we have multiple workspaces in the monorepo?
I switched to the public Hardhat API to avoid relying on internal modules, which are unstable and not guaranteed to maintain backward compatibility. using |
2 participants
Description
updated the code to use the public Hardhat API.
import { Artifacts } from 'hardhat/internal/artifacts'withimport { artifacts, Artifact } from 'hardhat'and rewrotegetArtifactusingartifacts.readArtifactSync.ethers.getContractFactoryFromArtifacttoethers.getContractFactory(artifact.abi, artifact.bytecode, signer).everything now works with the official Hardhat API without relying on internal modules.
Type of change
Checklist:
master, or there's a description of how to merge