Skip to content

fix: Hardhat artifact imports and contract factory usage #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Hardhat artifact imports and contract factory usage #2598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions pvt/helpers/src/contract.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
import { ethers } from 'hardhat';
import { ethers, artifacts, Artifact } from 'hardhat';
import { Contract } from 'ethers';
import { SignerWithAddress } from '@nomiclabs/hardhat-ethers/dist/src/signer-with-address';

import { Artifacts } from 'hardhat/internal/artifacts';
import { Artifact } from 'hardhat/types';
import path from 'path';
import { Dictionary } from 'lodash';

Expand All @@ -30,7 +28,7 @@ export async function deploy(

const artifact = getArtifact(contract);

const factory = await ethers.getContractFactoryFromArtifact(artifact, { signer: from, libraries });
const factory = await ethers.getContractFactory(artifact.abi, artifact.bytecode, from);
Copy link
Contributor

@jubeira jubeira Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also would need to send the libraries to link here: https://v2.hardhat.org/hardhat-runner/plugins/nomicfoundation-hardhat-ethers

const instance = await factory.deploy(...args);

return instance.deployed();
Expand Down Expand Up @@ -67,7 +65,6 @@ export function getArtifact(contract: string): Artifact {
artifactsPath = `${packagePath}/artifacts`;
}

const artifacts = new Artifacts(artifactsPath);
return artifacts.readArtifactSync(contract.split('/').slice(-1)[0]);
Copy link
Contributor

@jubeira jubeira Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we don't need the artifactsPath anymore? how is the global artifacts linked to the path in this case, considering we have multiple workspaces in the monorepo?

}

Expand Down