Skip to content

Conversation

@axelhzf
Copy link

@axelhzf axelhzf commented Nov 14, 2025

Closes #21026

Instead of relaying on the whileElementsMounted property, this code calls autoUpdate only when the Popover is open.

Changelog

Changed

  • Optimize Popover performance during resize events with multiple components on page

Testing / Reviewing

  • Create a page with many components that include Carbon tooltips using autoAlign (e.g., 100+ tooltips)
  • Resize the window
  • Observe the page performance

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@axelhzf axelhzf requested a review from a team as a code owner November 14, 2025 13:18
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

@axelhzf axelhzf changed the title [Popover] Enable floating autoupdate only when mounted [Popover] Enable floating autoupdate only when open Nov 14, 2025
@axelhzf
Copy link
Author

axelhzf commented Nov 14, 2025

I have read the DCO document and I hereby sign the DCO.

@netlify
Copy link

netlify bot commented Nov 14, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit d96a49f
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/691c37a55cc11700081f9e30
😎 Deploy Preview https://deploy-preview-21028--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 14, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit d96a49f
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/691c37a520ff4e0008a791cb
😎 Deploy Preview https://deploy-preview-21028--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@axelhzf
Copy link
Author

axelhzf commented Nov 14, 2025

recheck

@netlify
Copy link

netlify bot commented Nov 14, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d96a49f
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/691c37a542a445000812913d
😎 Deploy Preview https://deploy-preview-21028--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.39%. Comparing base (a4172c3) to head (d96a49f).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21028   +/-   ##
=======================================
  Coverage   92.38%   92.39%           
=======================================
  Files         515      515           
  Lines       37629    37634    +5     
  Branches     5738     5770   +32     
=======================================
+ Hits        34765    34771    +6     
+ Misses       2715     2713    -2     
- Partials      149      150    +1     
Flag Coverage Δ
main-packages 85.57% <100.00%> (+<0.01%) ⬆️
web-components 96.66% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Tooltip autoAlign cause performance problem on window resize

2 participants