Skip to content

[Popover] Enable floating autoupdate only when open #21028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
axelhzf wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Popover] Enable floating autoupdate only when open #21028

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a3b2d4
enable floating autoupdate only when mounted
axelhzf Nov 14, 2025
d96a49f
Merge branch 'main' into enable-floating-autoupdate-only-when-open
Gururajj77 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions packages/react/src/components/Popover/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@
}
}
});
const { refs, floatingStyles, placement, middlewareData } = useFloating(
const { refs, floatingStyles, placement, middlewareData, elements, update } = useFloating(
enableFloatingStyles
? {
placement: align,
Expand Down Expand Up @@ -342,14 +342,25 @@
padding: 16,
}),
autoAlign && hide(),
],
whileElementsMounted: autoUpdate,
]
}
: {}
// When autoAlign is turned off & the `enable-v12-dynamic-floating-styles` feature flag is not
// enabled, floating-ui will not be used
);

useEffect(() => {
if (!enableFloatingStyles) return;
if (open && elements.reference && elements.floating) {
const cleanup = autoUpdate(
elements.reference,
elements.floating,
update,
);
return cleanup;
}
}, [open, elements, update]);

Check warning on line 362 in packages/react/src/components/Popover/index.tsx

View workflow job for this annotation

GitHub Actions / lint 

React Hook useEffect has a missing dependency: 'enableFloatingStyles'. Either include it or remove the dependency array

const value = useMemo(() => {
return {
floating,
Expand Down
Loading