Improve fluidity of home-page #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the navbar and the body shifting to the left on the home page when the category cards load. The issue was also seen when navigating from a short page like /search to a long page like the home page. One could argue that it's a browser feature that users expect, but I argue that this is a case where overriding the browser's behavior is worth it for a smoother feel.
Filtering causes rapid changes in the list of categories. When each item has a transition from opacity 0 to opacity 1, the result can look like high-speed flickering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two changes that make the home page feel smoother:
sibling-index())These are subtle animations that I think improve the fluidity and smoothness of the platform.
The PR respects the
prefers-reduced-motionpreference and print mode. Any browsers without support forsibling-indexwill see only Change 2.Before (see that the page/navbar shifts left & right, and see the abrupt category cards compared to the staggered ones above)