Skip to content

Conversation

@max-hoffman
Copy link

privateRegex.Close()'s error handling was circumventing returning the module back to the pool. I don't understand the code well enough to know whether the other error handling logic is correct, but even in the error case I imagine we want to return the module objects to the pool.

@max-hoffman max-hoffman mentioned this pull request Dec 14, 2024
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but it won’t fix the issue. Modifying the code such that there’s a single module (without the pool altogether) still has the memory leak, albeit slower. This will help my mentioned PR reclaim memory faster in the event of an error, but it doesn’t solve the issue.

@Hydrocharged Hydrocharged deleted the max/fix-memory-leak branch March 3, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants