Skip to content

Return module to pool on regex.Close() #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Return module to pool on regex.Close() #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions regex.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,12 @@ func (pr *privateRegex) Close() (err error) {
if pr == nil || pr.mod == nil {
return nil
}
defer func() {
modulePool.Put(pr.mod)
pr.mod = nil
runtime.SetFinalizer(pr, nil)
}()

err = pr.closeRegexPtrs()
if nErr := pr.closeMatchPtr(); err == nil {
err = nErr
Expand All @@ -379,11 +385,6 @@ func (pr *privateRegex) Close() (err error) {
err = nErr
}
}
if pr.mod != nil {
modulePool.Put(pr.mod)
pr.mod = nil
runtime.SetFinalizer(pr, nil)
}
return err
}

Expand Down
Loading