Skip to content

Fix standardize_info(<fixest>) #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattansb merged 4 commits into from
Nov 16, 2025
Merged

Fix standardize_info(<fixest>) #1179

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d13e1da
fix #1178
mattansb Nov 13, 2025
f2f6206
fix tests
mattansb Nov 13, 2025
f94a1a1
typo
mattansb Nov 13, 2025
214a1c4
namespace
mattansb Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: parameters
Title: Processing of Model Parameters
Version: 0.28.2.9
Version: 0.28.2.10
Authors@R:
c(person(given = "Daniel",
family = "Lüdecke",
Expand Down
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# parameters (devel)

* fixed bug in `standardize_info(<fixest>)` that was preventing
`standardise_parameters()` from working for `fixest` models.

* `equivalence_test()` gets methods for objects from the *modelbased* package.

* Improved support for objects from package *survey*.
Expand Down
14 changes: 3 additions & 11 deletions R/standardize_info.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ standardize_info.default <- function(model,
insight::find_parameters(model, effects = "fixed", flatten = TRUE, ...)
}
types <- parameters_type(model)
# model_matrix <- as.data.frame(stats::model.matrix(model))
model_matrix <- as.data.frame(insight::get_modelmatrix(model))
model_data <- insight::get_data(model, source = "mf", verbose = FALSE)
wgts <- insight::get_weights(model, remove_na = TRUE)
Expand Down Expand Up @@ -321,11 +320,8 @@ standardize_info.default <- function(model,
#' @keywords internal
.std_info_response_smart <- function(model, info, data, model_matrix, types, robust = FALSE, w = NULL, ...) {
if (info$is_linear) {
if (inherits(model, c("gls", "lme"))) {
response <- insight::get_response(model)
} else {
response <- stats::model.frame(model)[[1]]
}
response <- insight::get_response(model)

means <- deviations <- rep(NA_real_, length = length(names(model_matrix)))
for (i in seq_along(names(model_matrix))) {
variable <- names(model_matrix)[i]
Expand Down Expand Up @@ -365,11 +361,7 @@ standardize_info.default <- function(model,

#' @keywords internal
.std_info_response_basic <- function(model, info, params, robust = FALSE, w = NULL, ...) {
if (inherits(model, c("gls", "lme"))) {
response <- insight::get_response(model)
} else {
response <- stats::model.frame(model)[[1]]
}
response <- insight::get_response(model)

if (info$is_linear) {
if (robust) {
Expand Down
Loading