fix(helper): Remove PyYAML dependency to resolve CI failures #14145
+262
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…builds" …" This reverts commit 89a3a64.
hunsche
requested review from
oliverchang and
vitaliset
and removed request for
oliverchang
hunsche
changed the title
Contributor
Author
|
/gcbrun trial_build.py zlib bad_example --fuzzing-engines libfuzzer --sanitizers address |
vitaliset
approved these changes
Oct 16, 2025
Removes the PyYAML dependency from infra/helper.py to fix a ModuleNotFoundError in the indexer build tests, which run in a minimal environment. The language and base_os_version properties in the Project class were refactored to manually parse project.yaml using regex, restoring CI compatibility without losing functionality.
hunsche
force-pushed
the
revert-14144-revert-14128-feat/base-os-version
branch
from
3534042 to
e1504a1
Compare
Contributor
Author
|
/gcbrun trial_build.py zlib bad_example --fuzzing-engines libfuzzer --sanitizers address |
Collaborator
|
Thanks! Note that helper.py is intended to be dependency-less, because it should be runnable by anybody just by checking out the OSS-Fuzz repo. |
pitrou
added a commit
to pitrou/oss-fuzz
that referenced
this pull request
Nov 17, 2025
It seems that, at some point (*), `infra/helper.py reproduce` stopped outputting the Docker logs, even when the reproducer triggers an assertion. (*) Probably because of some of the changes in google#14145
pitrou
reviewed
Nov 17, 2025
| ] + fuzzer_args | ||
|
|
||
| return run_function(run_args, architecture=architecture) | ||
| return run_function(run_args, err_result) |
Contributor
There was a problem hiding this comment.
I think this was an erroneous change as docker_run doesn't allow customizing the error result. Actually, this is passing err_result for docker_run's print_output parameter.
Collaborator
DavidKorczynski
added a commit
that referenced
this pull request
Nov 26, 2025
It seems that, at some point (*), `infra/helper.py reproduce` stopped outputting the Docker logs, even when the reproducer triggers an assertion. (*) Probably because of some of the changes in #14145 Co-authored-by: DavidKorczynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a
ModuleNotFoundErrorin therun indexer testsCI job by removing the externalPyYAMLdependency frominfra/helper.py.The original feature was reverted because
helper.pywas used in a minimal CI environment that does not include third-party libraries, causing the build to fail.This fix refactors the
Projectclass to manually parseproject.yamlfor thelanguageandbase_os_versionproperties using basic string operations. This approach preserves the required functionality while eliminating the dependency, ensuring compatibility with all CI environments.The fix was verified by successfully running the
index_build_testin an environment wherePyYAMLwas uninstalled.