infra: Fix reproduce not outputting Docker logs
#14299
Open
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that, at some point (*), `infra/helper.py reproduce` stopped outputting the Docker logs, even when the reproducer triggers an assertion. (*) Probably because of some of the changes in google#14145
pitrou
commented
Nov 17, 2025
|
|
||
|
|
||
| def docker_run(run_args, print_output=True, architecture='x86_64'): | ||
| def docker_run(run_args, *, print_output=True, architecture='x86_64'): |
Contributor
Author
There was a problem hiding this comment.
This is to ensure that we don't pass mismatching arguments like we did below.
Contributor
Author
|
I'm not sure why the infra tests failed but the error doesn't seem related. @hunsche @vitaliset Could you perhaps take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that, at some point (*),
infra/helper.py reproducestopped outputting the Docker logs, even when the reproducer triggers an assertion.(*) Probably because of some of the changes in #14145