-
Notifications
You must be signed in to change notification settings - Fork 69
Add reusable builder workflow #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sairon Based on my suggestion in the other PR, I added a reusable workflow for the builder. A nice side effect is the added grouping in the workflow run view https://github.com/home-assistant/docker-base/actions/runs/19587880102?pr=328. Overall the PR should work fine but might still have some rough edges. I wasn't quite sure where the best place to draw the line would be. We can either define most variables in the builder workflow itself and pass it as inputs or do some conditional magic in Let me know what you think. |
frenck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
This introduced a bug, the Python images are now tagged incorrectly, as the version suffix is attached to alpine version, while it should be |
Reusable workflow introduced in #328 broke suffixing of Python base images, as the format there is different than for the rest. Add special handling if Python version is set in the workflow.
Reusable workflow introduced in #328 incorrectly stores the latest versions in GH environment instead of in the output variables. Fix the target variable to correctly tag latest releases again.
Reusable workflow introduced in #328 incorrectly stores the latest versions in GH environment instead of in the output variables. Fix the target variable to correctly tag latest releases again.
Reusable workflow introduced in #328 incorrectly stores the latest versions in GH environment instead of in the output variables. Fix the target variable to correctly tag latest releases again.
Reusable workflow introduced in #328 broke suffixing of Python base images, as the format there is different than for the rest. Add special handling if Python version is set in the workflow.
I only looked at the code in detail now, as I didn't pay much attention once it was merged, but after reading it, I think I might prefer to do as much of the conditional magic on the side of the "caller" - currently I had some issues understanding what ends up where (hence the bunch of force-pushed commits above, which included incorrectly staged hunk). |
Thanks for the quick fix!
The added complexity is one of the small downsides unfortunately. Anything left I should help with at this point or would you prefer to do it yourself / leave it as is? |
Followup to #326 (comment)
https://docs.github.com/en/enterprise-cloud@latest/actions/how-tos/reuse-automations/reuse-workflows