-
Notifications
You must be signed in to change notification settings - Fork 14
Create chargeback role in obeservability FVT jobs #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
439589a to
ab1dee2
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/27cf94942622412b8b5edc34802f1f26 ❌ telemetry-openstack-meta-content-provider-master FAILURE in 8m 19s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c872820e5ec845c19469c829f1614704 ❌ telemetry-openstack-meta-content-provider-master FAILURE in 8m 31s |
c97a37f to
fa7a1a5
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ac32d3460afa49c6bea8477c6d682caa ❌ telemetry-openstack-meta-content-provider-master FAILURE in 8m 20s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/df94c0af44f44132a1691c208c31d6bb ❌ telemetry-openstack-meta-content-provider-master FAILURE in 9m 37s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f4fe4563163845b29cfcc66802b09069 ❌ telemetry-openstack-meta-content-provider-master FAILURE in 8m 48s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/907f26b23dd04800855dc5ff8fb24ae1 ❌ telemetry-openstack-meta-content-provider-master FAILURE in 8m 50s |
elfiesmelfie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the comments. I've identified most of the parts of the playbook that need to be removed, I think.
The new role needs to be added in.
I have a branch at https://github.com/elfiesmelfie/feature-verification-tests/tree/updates_to_alexy_chargeback_fvt, which I'm using to test this with changes required for the test-operator.
0d6ec3b to
16365be
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/320d096addc947359eb90b20bcfe60a0 ❌ telemetry-openstack-meta-content-provider-master FAILURE in 8m 33s |
elfiesmelfie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sync your change to master
16365be to
32c0283
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/77315e5cc97c45f797a7ce8a7e347d53 ✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 3h 01m 54s |
32c0283 to
d749cc4
Compare
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/telemetry-operator#720 is needed. |
d749cc4 to
396422c
Compare
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/openstack-operator#1614 is needed. |
68d8630 to
846ba3a
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8256641fa6ca4305a2bc2ccab04b6034 ❌ telemetry-openstack-meta-content-provider-master FAILURE in 6m 36s |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
recheck |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
20c90cf to
f448073
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2253c15aa58a4aaab9debd05077e7414 ✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 3h 08m 26s |
ceb9b9e to
a97ec02
Compare
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/telemetry-operator#720 is needed. |
|
recheck |
a97ec02 to
be764c7
Compare
| - name: Disable Cloudkitty Module (pyscripts) | ||
| ansible.builtin.command: | ||
| cmd: "{{ openstack_cmd }} rating module disable pyscripts" | ||
| register: disable_pyscripts | ||
| changed_when: "'Disabled' in disable_pyscripts.stdout or 'change' in disable_pyscripts.stdout" | ||
| failed_when: disable_pyscripts.rc != 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it actually matters if this is enabled or not. We're not testing it or using it. It should stay in whatever state it was in before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this script is not run in this PR, it should be removed until it is being used.
| Including an example of how to use your role (for instance, with variables passed in as parameters) is always nice for users too. | ||
|
|
||
| Each tasks/playbook.yml should be called independently via "ansible.builtin.import_role" with appropriate vars passed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Including an example of how to use your role (for instance, with variables passed in as parameters) is always nice for users too. | |
| Each tasks/playbook.yml should be called independently via "ansible.builtin.import_role" with appropriate vars passed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see any differences between suggested and current!?
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fc8140d1506d402f81e6f3f47907ebe3 ✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 54m 42s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d4f9ca3a537e4197b4049395d9b6fb1a ✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 33m 29s |
Jira: OSPRH-21447 Validate all applicable pods, services and containers are running
This is for testing to try work around the issue in openstack-k8s-operators/ci-framework#3400
* Add vars and override-checkout to cloudkitty job * Add roles a required projects to job
Once the PR is ready to merge, this commit can be dropped
bec5590 to
100dfb9
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e88c8f6f64784e4881280547d3a3ac39 ✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 30m 40s |
100dfb9 to
092e986
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
recheck |
add new role to feature-verifcation-tests that will testing new chargeback feature.
Depends-On: openstack-k8s-operators/telemetry-operator#720