-
Notifications
You must be signed in to change notification settings - Fork 9
fix: Add optional additional parameters for bridge creation #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add optional additional parameters for bridge creation #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for optional additional parameters when creating network bridges in the Linux IP feature implementation. The change allows users to pass extra configuration options to the underlying ip link add command for more flexible bridge creation.
Key Changes:
- Added
additional_parametersparameter to thecreate_bridgemethod with a default empty string value - Updated the command construction to include the additional parameters in the bridge creation command
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cd5ed6d to
9bd461d
Compare
9bd461d to
b2c3a70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b2c3a70 to
4c54d7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes intel#31 Signed-off-by: Rafał Głombiowski [email protected]
4c54d7b to
0b71f3e
Compare
Fixes #31