Skip to content

Conversation

@rafalglx
Copy link
Contributor

@rafalglx rafalglx commented Oct 24, 2025

Fixes #31

Copilot AI review requested due to automatic review settings October 24, 2025 13:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for optional additional parameters when creating network bridges in the Linux IP feature implementation. The change allows users to pass extra configuration options to the underlying ip link add command for more flexible bridge creation.

Key Changes:

  • Added additional_parameters parameter to the create_bridge method with a default empty string value
  • Updated the command construction to include the additional parameters in the bridge creation command

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rafalglx rafalglx force-pushed the fix__Add_optional_additional_parameters_for_bridge_creation branch from cd5ed6d to 9bd461d Compare October 24, 2025 13:14
@rafalglx rafalglx force-pushed the fix__Add_optional_additional_parameters_for_bridge_creation branch from 9bd461d to b2c3a70 Compare October 29, 2025 09:50
@rafalglx rafalglx requested a review from Copilot October 29, 2025 09:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rafalglx rafalglx force-pushed the fix__Add_optional_additional_parameters_for_bridge_creation branch from b2c3a70 to 4c54d7b Compare October 29, 2025 09:53
@rafalglx rafalglx requested a review from Copilot October 29, 2025 09:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rafalglx rafalglx force-pushed the fix__Add_optional_additional_parameters_for_bridge_creation branch from 4c54d7b to 0b71f3e Compare October 29, 2025 09:55
@mchromin mchromin merged commit 0a7533d into intel:main Oct 29, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Linux] Add optional additional parameters for bridge creation

3 participants