refactor(debit_routing): make the savings as the absolute value #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors how network savings information is calculated for co-badged card requests, shifting the calculation from percentage-based savings to absolute value-based savings. It introduces a new method for computing savings as absolute values, updates the main logic to use this method, and marks the previous percentage-based approach as deprecated.
Network savings calculation changes:
calculate_network_saving_infos_with_savings_as_absolute_value, which computes savings as the absolute difference between each network's fee and the most expensive fee, instead of using percentage savings.calculate_network_saving_infos_with_savings_as_absolute_value, which sorts the network costs, finds the highest fee, and calculates the savings for each network as an absolute value.Deprecation of old logic:
calculate_network_saving_infos_with_savings_as_percentageand marked as dead code, indicating it is no longer used.** Test Case **
Request
Response